Avoid byte[] allocations as part of byte[] comparisons #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes Utility.AreEqual to be non-allocating - Changes SymmetricSignatureProvider.Verify to not allocate a byte[] for a hash - Changes SymmetricSignatureProvider.Verify to use StartsWith for the comparison rather than Utility.AreEqual
src/Microsoft.IdentityModel.Tokens/SymmetricSignatureProvider.cs
Outdated
Show resolved
Hide resolved
|
Feedback addressed. Thanks. |
keegan-caruso
approved these changes
Jul 26, 2023
brentschmaltz
pushed a commit
that referenced
this pull request
Jul 28, 2023
* Avoid byte[] allocations in as part of byte[] comparisons - Changes Utility.AreEqual to be non-allocating - Changes SymmetricSignatureProvider.Verify to not allocate a byte[] for a hash - Changes SymmetricSignatureProvider.Verify to use StartsWith for the comparison rather than Utility.AreEqual * Use AreEqual instead of StartsWith
brentschmaltz
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Avoid byte[] allocations in as part of byte[] comparisons - Changes Utility.AreEqual to be non-allocating - Changes SymmetricSignatureProvider.Verify to not allocate a byte[] for a hash - Changes SymmetricSignatureProvider.Verify to use StartsWith for the comparison rather than Utility.AreEqual * Use AreEqual instead of StartsWith
brentschmaltz
pushed a commit
that referenced
this pull request
Sep 7, 2023
* Avoid byte[] allocations in as part of byte[] comparisons - Changes Utility.AreEqual to be non-allocating - Changes SymmetricSignatureProvider.Verify to not allocate a byte[] for a hash - Changes SymmetricSignatureProvider.Verify to use StartsWith for the comparison rather than Utility.AreEqual * Use AreEqual instead of StartsWith
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2154
Fixes #2153