Remove locks in SignatureProviders #1535
Conversation
src/Microsoft.IdentityModel.Tokens/AsymmetricSignatureProvider.cs
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,139 @@ | |||
| //------------------------------------------------------------------------------ | |||
There was a problem hiding this comment.
Should we rename this class to "DisposableObjectPool"?
additional test coverage
|
Kudos, SonarCloud Quality Gate passed!
|
|
@GeoK @keegan-caruso i upadate the PR, removing the locks in RsaCryptoServiceProxy and adding a programming possibility (not particularly elegant) opportunity to set the pool size. I struggled with naming and settled with DefaultSignatureProviderObjectPoolCacheSize, specifying using SignatureProvider in the name, rather than a more generic DefaultObjectPoolCacheSize, in case someone wanted to have different sizes (highly unlikely, however who knows). |
| @@ -41,6 +41,8 @@ public class CryptoProviderFactory | |||
| private static CryptoProviderFactory _default; | |||
| private static ConcurrentDictionary<string, string> _typeToAlgorithmMap = new ConcurrentDictionary<string, string>(); | |||
| private static object _cacheLock = new object(); | |||
| private static int _defaultSignatureProviderObjectPoolCacheSize = Environment.ProcessorCount * 4; | |||
There was a problem hiding this comment.
Just curios on why we decided to change the default object pool size?
There was a problem hiding this comment.
LGTM, curious about @GeoK 's questions and stress / perf findings
This PR adds an object pool that allows for the removal of locks when preforming crypto operations involving signatures. The 'objectpool' was copied from .net core as it is not available in 4.x.