-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple issues #345
Merged
Merged
Fix multiple issues #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should simplify and may also fix the issue described in #259 but requires further investigation. |
/azp run unit |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run unit |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run unit |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run unit |
Azure Pipelines successfully started running 1 pipeline(s). |
matt-FFFFFF
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/azp run unit |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This PR contains a number of small updates to address issues from our backlog as listed below
This PR fixes/adds/changes/removes
v3.0.2
onwards:azurerm_public_ip
prevents support of azurerm provider >= 3.0.0 #319threat_intel_mode
value forazurerm_firewall
resources is now explicitly set with a default value ofAlert
to support the latest provider versions. This matches the previous "default" value of the old provider.empty_map
local to thetomap()
function to fix Call to function "coalesce" failed: all arguments must have the same type. #340asc_export_resource_group_name
to fix Ability to rename ASC export resource group name #342generation
value for VPN gateways without using theadvanced
object to fix VPN Gateway Generations #333advanced
object to fix can't create active-active vpngw #232ip_configuration
input is specified via theadvanced
block for the following resource types:azurerm_virtual_network_gateway
(ExpressRoute and VPN)azurerm_firewall
advanced
object to fix BGP configuration on VPN gateways #334vpn_auth_types
attribute for thevpn_client_configuration
block on Virtual Network Gateway resourcesv0.15.1
(new minimum required to fixError: Output refers to sensitive values
) to latestv1.1.x
Breaking Changes
v3.0.2
onwards; To configure availability zones forazurerm_public_ip
resources using theadvanced
input, you must now provide zone inputs as a collection of string values within azones
input, asavailability_zone
is no longer supported by the provider. Valid values (at the time of writing), include:Generation2
for supported VPN gateway SKUs, customers may have their VPN gateway redeployed to the new version. Instructions for how to override this must be added to the release notes.plan
until users update the input forconfigure_connectivity_resources
. Longer term objective is to reduce the number of mandatory attributes within the schema using theoptional()
type wrapper once released as GA.Testing Evidence
Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have
main
branch/docs/wiki/whats-new.md
)