Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple issues #345

Merged
merged 15 commits into from
Apr 25, 2022
Merged

Fix multiple issues #345

merged 15 commits into from
Apr 25, 2022

Conversation

krowlandson
Copy link
Contributor

@krowlandson krowlandson commented Apr 19, 2022

Overview/Summary

This PR contains a number of small updates to address issues from our backlog as listed below

This PR fixes/adds/changes/removes

  1. Update module to support the AzureRM provider for Terraform from version v3.0.2 onwards:
    1. Fix Bug Report - AzureRM provider 3.0.0 availability zones error #309
    2. Fix azurerm_public_ip prevents support of azurerm provider >= 3.0.0 #319
  2. The threat_intel_mode value for azurerm_firewall resources is now explicitly set with a default value of Alert to support the latest provider versions. This matches the previous "default" value of the old provider.
  3. Cast empty_map local to the tomap() function to fix Call to function "coalesce" failed: all arguments must have the same type. #340
  4. Added new variable asc_export_resource_group_name to fix Ability to rename ASC export resource group name #342
  5. Add logic to automatically configure the generation value for VPN gateways without using the advanced object to fix VPN Gateway Generations #333
  6. Added input variables and logic to simplify configuring active-active mode for VPN gateways without using the advanced object to fix can't create active-active vpngw #232
  7. Added logic to suppress creation of Public IP resource(s) when a custom ip_configuration input is specified via the advanced block for the following resource types:
    1. azurerm_virtual_network_gateway (ExpressRoute and VPN)
    2. azurerm_firewall
  8. Added input variables for BGP configuration settings without using the advanced object to fix BGP configuration on VPN gateways #334
  9. Added missing vpn_auth_types attribute for the vpn_client_configuration block on Virtual Network Gateway resources
  10. Updated Wiki docs to reflect the included changes where covered in documentation
  11. Updated test framework to provide coverage of the included fixes
  12. Updated test strategy to ensure working versions are included from v0.15.1 (new minimum required to fix Error: Output refers to sensitive values) to latest v1.1.x

Breaking Changes

  1. To support the AzureRM provider for Terraform from version v3.0.2 onwards; To configure availability zones for azurerm_public_ip resources using the advanced input, you must now provide zone inputs as a collection of string values within a zones input, as availability_zone is no longer supported by the provider. Valid values (at the time of writing), include:
    1. "No-Zone",
    2. "1",
    3. "2",
    4. "3",
    5. "Zone-Redundant",
  2. By setting a preference to Generation2 for supported VPN gateway SKUs, customers may have their VPN gateway redeployed to the new version. Instructions for how to override this must be added to the release notes.
  3. In order to address some of the issues fixed above, we have had to make breaking changes to the mandatory schema. This will result in an error at plan until users update the input for configure_connectivity_resources. Longer term objective is to reduce the number of mandatory attributes within the schema using the optional() type wrapper once released as GA.

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located in the Enterprise-Scale repo in the directory: /docs/wiki/whats-new.md)

@krowlandson krowlandson added this to the v1.2.0 release milestone Apr 19, 2022
@krowlandson krowlandson self-assigned this Apr 19, 2022
@krowlandson krowlandson added the bug Something isn't working label Apr 21, 2022
@krowlandson
Copy link
Contributor Author

Should simplify and may also fix the issue described in #259 but requires further investigation.

@krowlandson krowlandson marked this pull request as ready for review April 22, 2022 16:40
@krowlandson krowlandson requested a review from matt-FFFFFF April 22, 2022 16:40
@krowlandson
Copy link
Contributor Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson
Copy link
Contributor Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson
Copy link
Contributor Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson
Copy link
Contributor Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson
Copy link
Contributor Author

image

New test strategy picking up correct versions 👍🏻

Copy link
Member

@matt-FFFFFF matt-FFFFFF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@krowlandson
Copy link
Contributor Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson
Copy link
Contributor Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson krowlandson merged commit 246cf7d into Azure:main Apr 25, 2022
@krowlandson krowlandson deleted the fix-issues branch April 25, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment