Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGP configuration on VPN gateways #334

Closed
dan-dimitrov opened this issue Apr 11, 2022 · 1 comment · Fixed by #345
Closed

BGP configuration on VPN gateways #334

dan-dimitrov opened this issue Apr 11, 2022 · 1 comment · Fixed by #345
Assignees
Labels
enhancement New feature or request PR-merged

Comments

@dan-dimitrov
Copy link

dan-dimitrov commented Apr 11, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Can we request for BGP parameters to be exposed on the VPN gateways please. These currently have to be configured through the advanced configuration as per the example below.

  advanced = {
    custom_settings_by_resource_type = {
      azurerm_virtual_network_gateway = {
        connectivity = {
          vpngw = {
            (var.connectivity_resources_location) = {
              enable_bgp    = true
              bgp_settings = [{
                asn               = "65515"
                peering_addresses = ["xx.xx.xx.xx"]
              }]
            }
          }
        }
      }
    }
  }
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Apr 11, 2022
@dan-dimitrov dan-dimitrov changed the title Feature Request BGP configuration on VPN gateways Apr 11, 2022
@krowlandson krowlandson self-assigned this Apr 12, 2022
@ghost ghost removed the Needs: Triage 🔍 Needs triaging by the team label Apr 12, 2022
@krowlandson krowlandson added the enhancement New feature or request label Apr 12, 2022
@krowlandson krowlandson added this to the v1.2.0 release milestone Apr 12, 2022
@krowlandson
Copy link
Contributor

Thank you for logging this @dan-dimitrov

Adding this to the input variable schema will be a breaking change so I will try to include this on the v1.2.0 release where we will be introducing other breaking changes.

krowlandson pushed a commit to krowlandson/terraform-azurerm-caf-enterprise-scale that referenced this issue Apr 21, 2022
@krowlandson krowlandson mentioned this issue Apr 21, 2022
6 tasks
@ghost ghost added the PR-referenced label Apr 21, 2022
krowlandson pushed a commit that referenced this issue Apr 25, 2022
* Cast `tomap()` to fix #340

* Add advanced input to fix #342

* Add logic to handle VPN GW generation to fix #333

* Add `advanced_vpn_settings`
- Fix #232
- Fix #334

* Custom `ip_configuration` disables PIP creation
- Fix #232

* Update to support provider version `v3.0.2`

* Link `secondary_location` to settings module

* Update to test VPN gateway without AZ

* Update resource type in ID prefix

* Update baseline for `v3.0.2` provider support

* Fix sensitive values error

* Update strategy to test using Terraform `v1.1.x`

* Update OPA guidance
@ghost ghost added PR-merged and removed PR-referenced labels Apr 25, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request PR-merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants