Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup pipeline to sync common engineering directory #353

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Setup pipeline to sync common engineering directory #353

merged 1 commit into from
Jan 24, 2020

Conversation

weshaggard
Copy link
Member

cc @Azure/azure-sdk-eng

@weshaggard weshaggard requested a review from mitchdenny January 24, 2020 00:55
@weshaggard weshaggard force-pushed the SetupCommonSyncPipeline branch from 8d58637 to ae25068 Compare January 24, 2020 01:00
heaths
heaths approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this goes through and the pipeline runs, should I move the TestResource scripts and replace them with stubs as we discussed?

@weshaggard weshaggard force-pushed the SetupCommonSyncPipeline branch from ae25068 to 099dfc6 Compare January 24, 2020 18:13
@weshaggard
Copy link
Member Author

After this goes through and the pipeline runs, should I move the TestResource scripts and replace them with stubs as we discussed?

Yes once this is goes in and starts running then you can move your test resource scripts into the eng\common directory and watch the updates flow :)

@weshaggard weshaggard merged commit f79dab5 into master Jan 24, 2020
@heaths heaths mentioned this pull request Jan 24, 2020
Closed
@weshaggard weshaggard mentioned this pull request Jan 24, 2020
Closed
sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this pull request Dec 3, 2020
@RickWinter
Samples were referencing field values before assignment (Azure#353)
008cea1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchdenny mitchdenny mitchdenny approved these changes

@heaths heaths heaths approved these changes

@JimSuplizio JimSuplizio JimSuplizio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weshaggard @mitchdenny @heaths @JimSuplizio