Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TestResources scripts to eng/common #358

Closed
heaths opened this issue Jan 24, 2020 · 6 comments
Closed

Move TestResources scripts to eng/common #358

heaths opened this issue Jan 24, 2020 · 6 comments
Assignees
Labels
EngSys This issue is impacting the engineering system.

Comments

@heaths
Copy link
Member

heaths commented Jan 24, 2020

After this goes through and the pipeline runs, should I move the TestResource scripts and replace them with stubs as we discussed?

Yes once this is goes in and starts running then you can move your test resource scripts into the eng\common directory and watch the updates flow :)

Originally posted by @weshaggard in #353 (comment)

@heaths heaths self-assigned this Jan 24, 2020
@heaths heaths added the EngSys This issue is impacting the engineering system. label Jan 24, 2020
@heaths
Copy link
Member Author

heaths commented Jan 24, 2020

Be sure to update all repos' pipelines to use the direct script, but create stubs for end users. Or, rather, since we haven't documented how to use them, maybe it's not worth stubs directly under eng. @weshaggard and @danieljurek, what do you think?

@weshaggard
Copy link
Member

I'd only add stubs if it actually helps in some way if it doesn't help I'd remove that layer of indirection and simply call the scripts directly from the eng\common directory.

@danieljurek
Copy link
Member

This should include a parameterized template such that the archetype-sdk-tests.yml files do not invoke the scripts directly but import the template to do so.

@heaths
Copy link
Member Author

heaths commented Apr 3, 2020

The azure-sdk-for-net repo isn't using this yet. Not sure about the other languages.

Additionally, this repo needs to be updated from the .NET repo first.

@heaths heaths reopened this Apr 3, 2020
@danieljurek
Copy link
Member

danieljurek commented Apr 6, 2020

@heaths
Copy link
Member Author

heaths commented Apr 13, 2020

Is this one done? I went ahead and checked .NET since I know that's completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

3 participants