-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move TestResources scripts to eng/common #358
Comments
Be sure to update all repos' pipelines to use the direct script, but create stubs for end users. Or, rather, since we haven't documented how to use them, maybe it's not worth stubs directly under eng. @weshaggard and @danieljurek, what do you think? |
I'd only add stubs if it actually helps in some way if it doesn't help I'd remove that layer of indirection and simply call the scripts directly from the eng\common directory. |
This should include a parameterized template such that the archetype-sdk-tests.yml files do not invoke the scripts directly but import the template to do so. |
The azure-sdk-for-net repo isn't using this yet. Not sure about the other languages. Additionally, this repo needs to be updated from the .NET repo first. |
|
Is this one done? I went ahead and checked .NET since I know that's completed. |
Yes once this is goes in and starts running then you can move your test resource scripts into the eng\common directory and watch the updates flow :)
Originally posted by @weshaggard in #353 (comment)
The text was updated successfully, but these errors were encountered: