-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep dynamic resource allocation/deallocation scripts up to date #934
Comments
A couple other options that I think I prefer a little more:
No matter what we end up doing we need to be sure that the scripts and/or tools are versioned so that servicing release can use the exact version they used when we do older builds. It should not depend on pulling the latest because that is almost guaranteed to break. |
You mentioned that this will be solved by the changes you're making to mirror in scripts and tools from azure-sdk-tools. |
@heaths @danieljurek we now have the infra in place to sync the shared script files. So you guys should be good to move your ARM scripts into the eng/common directory in the azure-sdk-tools repo to have it sync to the other repos. |
That is tracked in Azure/azure-sdk-tools#358 |
Closing this issue as dup of Azure/azure-sdk-tools#358 |
Changes to the resource allocation/deallocation scripts should be reflected in all repos and those scripts should be consistent.
Ideas discussed so far:
Scripts reach up to a public location and validate a hash of the contents, erroring if the has does not match their hash -- if we did this we'd need to determine how to do alerting (do all pipelines break when the hash changes meaning that the current executing script is outdated?)
Submodules
Scripts bootstrap from a well known public location -- this would mean that the script in the repo may not be what is executed and that would create confusion. Recommend against this approach.
The text was updated successfully, but these errors were encountered: