Add "weekly" convention to pipeline generator #1026
Conversation
|
The changes here look reasonable but before we move forward with enabling this generally across the board I'd like to make sure we have the correct conventions for things here. As it stands we will essentially have a duplicated pipeline with the name "- tests-weekly" instead of "- tests" but we haven't really setup any convention that would allow people to easily fork their test matrix based on that. While they could check the pipeline name I'd prefer that we don't have those sorts of checks all over our yml files but instead we have it localized in one place that defines some variables that can be used. We could also have the generator set those as parameters in the pipelines we create. |
|
I'm still lamenting the fact that we haven't managed to converge the live testing and nightly CI builds in some fashion. Even if we just bolted on the live test structure that has been established to the main CI run. |
|
(I should note that is a much larger conversation than this PR though :P) |
|
I agree @mitchdenny I still want to combine the tests and ci yml files together and just control what runs based on the pipeline that we are triggering. |
|
@mitchdenny I should also call out that we are combining these for C++ Azure/azure-sdk-for-cpp#608 as we are bringing them online for the first time. |
|
@benbp I think you are taking this onwards? This change LGTM, I hadn't reviewed because it was in draft. |
|
Yes @mitchdenny. I need to loop back and merge. |
fc230fa to
e114fe9
Compare
|
Rebased, and tested. Still works! :D |
|
@benbp do you plan to manually run this as you on-board new repo's for now? Eventually we should get it added to https://github.com/Azure/azure-sdk-tools/blob/master/eng/pipelines/pipeline-generation.yml which is our daily generation run. |
* Update README.md Fix the directory name * Update README.md
Fixes #1025