-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Out null deployment #1029
Out null deployment #1029
Conversation
.../Azure.Sdk.Tools.PipelineGenerator/Conventions/WeeklyIntegrationTestingPipelineConvention.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script changes LGTM, though assigning to $null
is faster when performance matters more (just a tip).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pipeline Generator changes need to be moved out (you've got it covered in another PR).
cd313ac
to
923f168
Compare
I updated this PR to remove the pipeline generation changes. |
…e. Logging is not affected.
923f168
to
964d5ac
Compare
/check-enforcer reset |
…e. Logging is not affected. (#1029)
Fixes #1028
Example lacking Out-Null (scroll to the bottom of the logs) -- https://dev.azure.com/azure-sdk/internal/_build/results?buildId=523905&view=logs&j=b28a1a35-334b-5681-3876-e5562b5e8062&t=ff48ff62-22a8-5437-aae5-18a32a8994ec&l=237
Example with Out-Null (scroll to the bottom of the logs) -- https://dev.azure.com/azure-sdk/internal/_build/results?buildId=543132&view=logs&j=b28a1a35-334b-5681-3876-e5562b5e8062&t=85d3da62-e026-56d3-c19c-0f96227fb514&l=160