Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenCensus kind mapping and EH update #7624

Merged
merged 15 commits into from
Jan 2, 2020
Merged

OpenCensus kind mapping and EH update #7624

merged 15 commits into from
Jan 2, 2020

Conversation

lmazuel
Copy link
Member

@lmazuel lmazuel commented Oct 4, 2019

No description provided.

@AutorestCI
Copy link
Contributor

AutorestCI commented Oct 4, 2019 •
edited
Loading

(message created by the CI based on PR content)

Installation instruction

Package azure-core-tracing-opencensus

You can install the package azure-core-tracing-opencensus of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@tracing_producer#egg=azure-core-tracing-opencensus&subdirectory=azure-core-tracing-opencensus"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@tracing_producer#egg=azure-core-tracing-opencensus&subdirectory=azure-core-tracing-opencensus"

If you have a local clone of this repository, you can also do:

  • git checkout tracing_producer
  • pip install -e ./azure-core-tracing-opencensus

Or build a wheel file to distribute for testing:

  • git checkout tracing_producer
  • pip wheel --no-deps ./azure-core-tracing-opencensus

Package azure-eventhubs

You can install the package azure-eventhubs of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@tracing_producer#egg=azure-eventhubs&subdirectory=azure-eventhubs"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@tracing_producer#egg=azure-eventhubs&subdirectory=azure-eventhubs"

If you have a local clone of this repository, you can also do:

  • git checkout tracing_producer
  • pip install -e ./azure-eventhubs

Or build a wheel file to distribute for testing:

  • git checkout tracing_producer
  • pip wheel --no-deps ./azure-eventhubs

Direct download

Your files can be directly downloaded here:

lmolkova
lmolkova previously approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but 'consumer' maps to 'client' kind. We should not be reporting it for event hubs

@lmazuel lmazuel changed the title Make Producer in OpenCensus point to Client and EH update OpenCensus kind mapping and EH update Dec 20, 2019
@lmazuel lmazuel mentioned this pull request Dec 20, 2019
Closed
@lmazuel lmazuel mentioned this pull request Dec 21, 2019
Closed
@lmazuel lmazuel mentioned this pull request Dec 21, 2019
Closed
2 tasks
lmolkova
lmolkova previously approved these changes Dec 26, 2019
View reviewed changes
lmolkova
lmolkova previously approved these changes Dec 27, 2019
View reviewed changes
yunhaoling
yunhaoling approved these changes Dec 31, 2019
View reviewed changes
Copy link
Contributor

@yunhaoling yunhaoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yunhaoling
Copy link
Contributor

/azp run python - eventhubs - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lmazuel lmazuel merged commit ac853d8 into master Jan 2, 2020
@lmazuel lmazuel deleted the tracing_producer branch January 2, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanste johanste johanste left review comments

@yunhaoling yunhaoling yunhaoling approved these changes

@lmolkova lmolkova lmolkova left review comments

@annatisch annatisch Awaiting requested review from annatisch

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99

@YijunXieMS YijunXieMS Awaiting requested review from YijunXieMS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lmazuel @AutorestCI @yunhaoling @lmolkova @johanste @YijunXieMS