Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EventHubs] Distributed tracing with OpenTelemtery: wrong diagnostics-id is added to the message #8810

Closed
lmolkova opened this issue Nov 22, 2019 · 2 comments
Closed

[EventHubs] Distributed tracing with OpenTelemtery: wrong diagnostics-id is added to the message #8810

lmolkova opened this issue Nov 22, 2019 · 2 comments
Assignees
@lmazuel
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.

Comments

@lmolkova
Copy link
Member

EventHubs trace_message:

As a result, diagnostic-id carries parent (if any) context, rather than message span context.
@lmazuel lmazuel added Azure.Core Client This issue points to a problem in the data-plane of the library. labels Nov 22, 2019
@lmazuel
Copy link
Member

lmazuel commented Nov 22, 2019 •
edited
Loading

I'll make this is correct beofre merging #7703, thanks!

@lmazuel lmazuel self-assigned this Dec 21, 2019
lmazuel added a commit that referenced this issue Dec 21, 2019
@lmazuel
Fix #8810
1b7ea9d
@lmazuel
Copy link
Member

lmazuel commented Dec 21, 2019

Fixed in #7624

@lmazuel lmazuel closed this as completed Dec 21, 2019
lmazuel added a commit that referenced this issue Jan 2, 2020
@lmazuel
OpenCensus kind mapping and EH update (#7624)
ac853d8 
* Make Producer in OpenCensus point to Client and EH update

* CONSUMER is CLIENT type

* Use Producer in EH

* Map internal to Client in OpenCensus

* Docstring

* Fix #9099

* Fix #8810

* Fix #9084

* pylint

* Internal is mapped to Client

* INTERNAL is UNSPECIFIED

* Do not link if no traceparent

* Use a mapping for Kind

* Avoid unecessary dict copy
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lmazuel lmazuel

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmazuel @lmolkova