Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK and tests for hybrid RP #7482

Merged
merged 5 commits into from
Oct 24, 2019
Merged

SDK and tests for hybrid RP #7482

merged 5 commits into from
Oct 24, 2019

Conversation

farehar
Copy link
Contributor

@farehar farehar commented Sep 5, 2019 •
edited by isra-fel
Loading

@farehar farehar requested a review from erich-wang as a code owner September 5, 2019 17:57
@isra-fel isra-fel self-assigned this Sep 6, 2019
@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. needs-review labels Sep 6, 2019
@isra-fel isra-fel assigned farehar and unassigned isra-fel Sep 6, 2019
@farehar farehar requested a review from isra-fel September 6, 2019 21:37
isra-fel
isra-fel suggested changes Sep 7, 2019
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @farehar ,

  • could you put a link to the swagger review PR(s) in description
  • As a public preview SDK, its spec should also be in the public spec repo. Please update generate.ps1 so that it doesn't point to the private spec repo
  • And you'll see a .txt file after running generate.ps1, please also check it in
  • please also check in AssemblyInfo.cs, and make sure the versions in it are updated

Thanks

@isra-fel
Copy link
Member

@farehar ping on this

@farehar
Copy link
Contributor Author

farehar commented Oct 15, 2019

@isra-fel : One of the feedback was to move our swagger spec to public repository. We weren't ready to do that last month. I've created a pull request in public repository today. If i address rest of the feedback, would we be able to merge before swagger spec PR is complete?

@isra-fel
Copy link
Member

@isra-fel : One of the feedback was to move our swagger spec to public repository. We weren't ready to do that last month. I've created a pull request in public repository today. If i address rest of the feedback, would we be able to merge before swagger spec PR is complete?

Nope, sorry. SDK should be generated based on merged spec.

@farehar
Copy link
Contributor Author

farehar commented Oct 23, 2019

@isra-fel : I've addressed all the feedback. Here's the link to our swagger spec in public repository https://github.com/Azure/azure-rest-api-specs/tree/master/specification/hybridcompute/resource-manager

isra-fel
isra-fel reviewed Oct 23, 2019
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farehar Please CIL thanks

@isra-fel isra-fel merged commit 344b67f into Azure:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

@erich-wang erich-wang Awaiting requested review from erich-wang

Assignees

@farehar farehar

Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farehar @isra-fel