Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid RP. enable delete operation #7568

Merged
merged 22 commits into from
Oct 23, 2019
Merged

Hybrid RP. enable delete operation #7568

merged 22 commits into from
Oct 23, 2019

Conversation

farehar
Copy link
Contributor

@farehar farehar commented Oct 22, 2019

We need to generate apis for delete operations. removing disable flag from readme.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 22, 2019

In Testing, Please Ignore

[Logs] (Generated from 441b9f2, Iteration 2)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 22, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@farehar
Copy link
Contributor Author

farehar commented Oct 22, 2019

@fengzhou-msft : Will appreciate quick review and sign off. Need to generate sdks.

@farehar
Copy link
Contributor Author

farehar commented Oct 22, 2019

@fengzhou-msft : Can you please merge this?

@farehar farehar closed this Oct 22, 2019
@farehar farehar reopened this Oct 22, 2019
@fengzhou-msft
Copy link
Member

@farehar I've sent a request for merge permission. will merge it when i have the permission

@farehar
Copy link
Contributor Author

farehar commented Oct 23, 2019

@fengzhou-msft : How long is that expected to take? We'd like to merge this asap so we can proceed with api generations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants