[LiveMetricsExporter] Add Filtering Support part 7 - Sync Model change for Duration

sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Internals/Filtering/DerivedMetric.cs

@@ -192,6 +192,11 @@ private void CreateProjection()
                     // special case - for TimeSpan values ToString() will not result in a value convertable to double, so we must take care of that ourselves
                     if (fieldType == typeof(TimeSpan))
                     {
+                        if (fieldExpression.Type == typeof(string))
+                        {
+                            MethodInfo? parseMethod = typeof(TimeSpan).GetMethod("Parse", new[] { typeof(string) });
+                            fieldExpression = Expression.Call(parseMethod!, fieldExpression);
+                        }
                         fieldExpression = Expression.Property(fieldExpression, "TotalMilliseconds");
                     }
                 }

sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Internals/Filtering/Filter.cs

@@ -286,6 +286,11 @@ private static Type GetPropertyTypeFromFieldName(string fieldName)
                         typeof(TTelemetry),
                         (type, propertyName) => type.GetProperty(propertyName, BindingFlags.Instance | BindingFlags.Public).PropertyType);
 
+                if (fieldName == "Duration")
+                {
+                    propertyType = typeof(TimeSpan);
+                }
+
                 if (propertyType == null)
                 {
                     string propertyNotFoundMessage = string.Format(
@@ -555,6 +560,11 @@ private Expression ProduceComparatorExpressionForSingleFieldCondition(Expression
                     if (fieldType == typeof(TimeSpan))
                     {
                         this.ThrowOnInvalidFilter(fieldType, !this.comparandTimeSpan.HasValue);
+                        if (fieldExpression.Type == typeof(string))
+                        {
+                            MethodInfo parseMethod = typeof(TimeSpan).GetMethod("Parse", new[] { typeof(string) });
+                            fieldExpression = Expression.Call(parseMethod, fieldExpression);
+                        }
 
                         switch (this.predicate)
                         {

sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Internals/Filtering/FilterConjunctionGroup.cs

@@ -47,7 +47,7 @@ public bool CheckFilters(TTelemetry document, out CollectionConfigurationError[]
                     ////errorList.Add(
                     ////    CollectionConfigurationError.CreateError(
                     ////        CollectionConfigurationErrorType.FilterFailureToRun,
-                    ////        string.Format(CultureInfo.InvariantCulture, "Failter failed to run: {0}.", filter),
+                    ////        string.Format(CultureInfo.InvariantCulture, "Filter failed to run: {0}.", filter),
                     ////        e));
                     filterPassed = false;
                 }

sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/tests/Azure.Monitor.OpenTelemetry.LiveMetrics.Tests/Filtering/DerivedMetricTests.cs

@@ -277,6 +277,32 @@ public void DerivedMetricProjectsCorrectlyWhenTimeSpan()
             Assert.Equal(120, projection);
         }
 
+        [Fact]
+        public void DerivedMetricProjectsCorrectlyWhenDurationIsString()
+        {
+            // ARRANGE
+            var metricInfo = new DerivedMetricInfo(
+                id: "Metric1",
+                telemetryType: TelemetryType.Request,
+                filterGroups: new FilterConjunctionGroupInfo[0],
+                projection: "Duration",
+                aggregation: DerivedMetricInfoAggregation.Avg
+            );
+
+            var durationString = TimeSpan.FromMilliseconds(120).ToString();
+            var telemetry = new DocumentMockWithStringDuration(durationString);
+
+            // ACT
+            CollectionConfigurationError[] errors;
+            var metric = new DerivedMetric<DocumentMockWithStringDuration>(metricInfo, out errors);
+            double projection = metric.Project(telemetry);
+
+            // ASSERT
+            Assert.Equal(DerivedMetricInfoAggregation.Avg, metric.AggregationType);
+            Assert.Empty(errors);
+            Assert.Equal(120, projection);
+        }
+
         [Fact(Skip = "Unknown failure.")]
         public void DerivedMetricReportsErrorsForInvalidFilters()
         {

sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/tests/Azure.Monitor.OpenTelemetry.LiveMetrics.Tests/Filtering/DocumentMockWithStringDuration.cs

@@ -0,0 +1,17 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+namespace Azure.Monitor.OpenTelemetry.LiveMetrics.Internals.Filtering.Tests
+{
+    using Azure.Monitor.OpenTelemetry.LiveMetrics.Models;
+
+    internal class DocumentMockWithStringDuration : DocumentIngress
+    {
+        internal DocumentMockWithStringDuration(string duration)
+        {
+            Duration = duration;
+        }
+
+        public string Duration { get; set; }
+    }
+}

sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/tests/Azure.Monitor.OpenTelemetry.LiveMetrics.Tests/Filtering/FilterTests.cs

@@ -912,6 +912,20 @@ public void FilterTimeSpanGarbageComparand()
             Assert.Throws<ArgumentOutOfRangeException>(() => new Filter<DocumentMock>(equalsValue));
         }
 
+        [Fact]
+        public void FilterDurationAsString()
+        {
+            // ARRANGE
+            var equalsValue = new FilterInfo("Duration", FilterInfoPredicate.Equal, "123");
+
+            // ACT
+            bool result1 = new Filter<DocumentMockWithStringDuration>(equalsValue).Check(new DocumentMockWithStringDuration(TimeSpan.Parse("123", CultureInfo.InvariantCulture).ToString()));
+            bool result2 = new Filter<DocumentMockWithStringDuration>(equalsValue).Check(new DocumentMockWithStringDuration(TimeSpan.Parse("124", CultureInfo.InvariantCulture).ToString()));
+
+            // ASSERT
+            Assert.True(result1);
+            Assert.False(result2);
+        }
         #endregion
 
         #region String