[LiveMetricsExporter] Add Filtering Support part 7 - Sync Model change for Duration #43080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there an actual issue, or are you anticipating one? If there is an actual issue, can you explain that in detail in the PR description? |
…he fieldExpression is of type `string`. In other words, the conversion should only happen if Document.Duration field type is `string`. If there are other field type of `TimeSpan`, don't do this conversion.
I've updated the PR description and added some unit tests. |
rajkumar-rangaraj
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR following up on #41523.
Models for all telemetry's
Durationfield changed fromTimeSpantostring. Changing the code to parse the field toTimeSpanto facilitate comparisons actions later.To be specific, these two
DocumentIngressimplementations haveDurationfield but is of typestring:azure-sdk-for-net/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Generated/Models/Request.cs
Line 45 in 9ce35d5
azure-sdk-for-net/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Generated/Models/RemoteDependency.cs
Line 45 in 9ce35d5