Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication][PhoneNumbers] Fix areacodes pageable bug #42629

Merged

Conversation

sorrego-msft
Copy link
Contributor

Fixing an issue with pageables when getting areacodes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sorrego-msft:

Your account is missing the required public organization memberships required for Azure SDK contributors. Please review the Azure SDK onboarding documentation and make use of the onboarding Teams channel for assistance.

@jsquire
Copy link
Member

jsquire commented Mar 12, 2024

Please close #42513 if this supersedes it.

@sorrego-msft sorrego-msft requested a review from jsquire March 13, 2024 16:33
@sorrego-msft
Copy link
Contributor Author

sorrego-msft commented Mar 13, 2024

Followed the onboarding doc and set my organisations to public, and closed the previous PR.
Please review @jsquire

@jsquire jsquire dismissed their stale review March 13, 2024 16:52

Account issues have been corrected.

@sorrego-msft sorrego-msft merged commit 35406ec into Azure:main Mar 13, 2024
18 checks passed
angiurgiu pushed a commit that referenced this pull request Mar 20, 2024
* Fix areacodes pageable bug

* Update recordings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants