Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Communication][PhoneNumbers] Fix paging issue in get areacodes #42513

Closed
wants to merge 1 commit into from
Closed

[Communication][PhoneNumbers] Fix paging issue in get areacodes #42513

wants to merge 1 commit into from

Conversation

sorrego-msft
Copy link
Contributor

Removing an if statement that would cause the areacodes pageable to stop returning pages.

@github-actions github-actions bot added Communication - Phone Numbers Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Mar 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

Thank you for your contribution @sorrego-msft! We will review the pull request and get back to you soon.

jsquire
jsquire requested changes Mar 8, 2024
View reviewed changes
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sorrego-msft:

Your account is missing the required "write" permissions and public organization memberships required for Azure SDK contributors. Please review the Azure SDK onboarding documentation and make use of the onboarding Teams channel for assistance.

Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

@sorrego-msft
Copy link
Contributor Author

sorrego-msft commented Mar 8, 2024 •
edited
Loading

Hey @jsquire,
Thanks for the comments, I used to have the permissions and I just noticed that those were missing, already requested the write and push permissions.

Regarding CODEOWNERS, I don't think I qualify as only managers appear as code owners, no SE from my team is currently tagged as codeowner.

@jsquire jsquire mentioned this pull request Mar 12, 2024
Merged
@sorrego-msft sorrego-msft deleted the sorrego/UpdateGetAreaCodesPageables branch March 13, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsquire jsquire jsquire requested changes

@danielortega-msft danielortega-msft danielortega-msft approved these changes

@miguhern miguhern Awaiting requested review from miguhern

@whisper6284 whisper6284 Awaiting requested review from whisper6284 whisper6284 is a code owner

@RoyHerrod RoyHerrod Awaiting requested review from RoyHerrod

@danielav7 danielav7 Awaiting requested review from danielav7 danielav7 is a code owner

Assignees
No one assigned
Labels
Communication - Phone Numbers Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sorrego-msft @jsquire @danielortega-msft @Sforrego