Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Service Bus] Improve errors and update API docs as per the feedback from UX study #11592

Merged
merged 3 commits into from
Apr 27, 2020
Merged

[Service Bus] Improve errors and update API docs as per the feedback from UX study #11592

merged 3 commits into from
Apr 27, 2020

Conversation

ShivangiReja
Copy link
Member

  • Improve error message when user attempts to settle a peeked message.
  • Update ServiceBusSender docs by making it clear that it can be used for session entities.
  • Update Processor docs by including that this is used for receiving messages, not sending messages.
  • Include default ReceiveMode in more places in documentation.
  • Add ClientBuilderExtensions to be used for dependency injection.

@ShivangiReja ShivangiReja self-assigned this Apr 25, 2020
@ShivangiReja ShivangiReja added Service Bus Client This issue points to a problem in the data-plane of the library. labels Apr 25, 2020
JoshLove-msft
JoshLove-msft reviewed Apr 25, 2020
View reviewed changes
sdk/servicebus/Azure.Messaging.ServiceBus/src/Receiver/ServiceBusReceiver.cs
/// </summary>
private void ThrowIfLockTokenIsEmpty(string lockToken)
{
if (Guid.Parse(lockToken) == Guid.Empty)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ShivangiReja ShivangiReja merged commit c0762c9 into Azure:master Apr 27, 2020
This was referenced Apr 27, 2020
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshLove-msft JoshLove-msft JoshLove-msft approved these changes

@jsquire jsquire Awaiting requested review from jsquire

@nemakam nemakam Awaiting requested review from nemakam

Assignees

@ShivangiReja ShivangiReja

Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShivangiReja @JoshLove-msft