Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when user attempts to settle a peeked message #11521

Closed
JoshLove-msft opened this issue Apr 23, 2020 · 1 comment
Closed
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Milestone

Comments

@JoshLove-msft
Copy link
Member

JoshLove-msft commented Apr 23, 2020

The current message:
The lock supplied is invalid. Either the lock expired, or the message has already been removed from the queue, or was received by a different receiver instance.

This goes along with a ServiceBusException with a FailureReason of MessageLockLost.

This isn't really accurate, because the user never had the lock to begin with. We can probably do the validation on the client and prevent the settlement on message with no LockToken. We would instead throw an InvalidOperationException if the LockToken is empty.

@JoshLove-msft JoshLove-msft added Service Bus Client This issue points to a problem in the data-plane of the library. labels Apr 23, 2020
@JoshLove-msft JoshLove-msft added this to the [2020] May milestone Apr 23, 2020
@ShivangiReja
Copy link
Member

Closed with #11592

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this issue Dec 15, 2020
add marketplaceordering config (Azure#11521)

* add marketplaceordering config

* fix config
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

No branches or pull requests

2 participants