Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change gulpfile to TypeScript, update SwaggerToSDK generator version #5

Merged
2 commits merged into from
Sep 17, 2018
Merged

Change gulpfile to TypeScript, update SwaggerToSDK generator version #5

2 commits merged into from
Sep 17, 2018

Conversation

ghost
Copy link

@ghost ghost commented Sep 17, 2018

No description provided.

@ghost ghost added this to the Sprint-124 milestone Sep 17, 2018
@ghost ghost self-assigned this Sep 17, 2018
@ghost ghost requested review from amarzavery, RikkiGibson and kpajdzik September 17, 2018 21:28
@ghost ghost added the in progress label Sep 17, 2018
RikkiGibson
RikkiGibson reviewed Sep 17, 2018
View reviewed changes
gulpfile.ts Outdated
return readmeTypeScriptMdFileContents.match(/output-folder: (\S*)/)[1];
}

function npmInstall(packageFolderPath) {
execSync(`npm install`, { cwd: packageFolderPath, stdio: ['ignore', 'ignore', 'pipe'] });
function npmInstall(packageFolderPath: string): any {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this return type used now?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I added it just so that npmInstall() behaved a little more like execSync(), but since I wasn't using it I'll just make it void.

@ghost ghost merged commit e26f3fc into master Sep 17, 2018
@ghost ghost deleted the daschult/tsGulp branch September 17, 2018 22:09
@ghost ghost removed the in progress label Sep 17, 2018
HarshaNalluru referenced this pull request in HarshaNalluru/azure-sdk-for-js Apr 12, 2019
Merge pull request #5 from Azure/daschult/tsGulp
bf17adf 
Change gulpfile to TypeScript, update SwaggerToSDK generator version
HarshaNalluru referenced this pull request in HarshaNalluru/azure-sdk-for-js Apr 12, 2019
@amarzavery
Merge pull request #5 from amarzavery/init2
b1816ab 
Initial PR for Azure SB over amqp
ramya0820 pushed a commit to ramya0820/azure-sdk-for-js that referenced this pull request May 1, 2019
@amarzavery
Merge pull request Azure#5 from amarzavery/init
0e8043f 
renamed methods and added IotHubConnectionConfig
bterlson pushed a commit to bterlson/azure-sdk-for-js that referenced this pull request May 24, 2019
@amarzavery
Merge pull request Azure#5 from amarzavery/fixStringBody
2339430 
fixing moment dependency strictly to 2.18.1
daviwil pushed a commit to daviwil/azure-sdk-for-js that referenced this pull request Jun 7, 2019
@RikkiGibson
Merge pull request Azure#5 from Azure/XmlSupport
70b560e 
Rename bodyAsJson to parsedBody
ramya-rao-a referenced this pull request in ramya-rao-a/azure-sdk-for-js Aug 23, 2019
@chradek
Merge pull request #5 from ramya-rao-a/better-docs-ux
7e75aeb 
[Event Hubs] Improve docs based on ux study
@ashishsahu2008 ashishsahu2008 mentioned this pull request Apr 3, 2020
Closed
sarangan12 referenced this pull request in sarangan12/azure-sdk-for-js Jul 14, 2020
@olydis
Merge pull request #5 from Azure/olydis-patch-1
5b75f62 
Update autorest.typescript.csproj
sarangan12 referenced this pull request in sarangan12/azure-sdk-for-js Jul 14, 2020
@daviwil
Merge pull request #5 from daviwil/add-model-transforms
8cd736d 
Add initial model transforms
KarishmaGhiya pushed a commit that referenced this pull request Sep 28, 2023
@mpodwysocki @KarishmaGhiya
# This is a combination of 5 commits.
51ed5fc 
# This is the 1st commit message:

fix test for IBC

# This is the commit message #2:

[identity] Update MSAL to use its own open browser

# This is the commit message #3:

update open browser code

# This is the commit message #5:

formatting
KarishmaGhiya pushed a commit that referenced this pull request Oct 2, 2023
@mpodwysocki @KarishmaGhiya
# This is a combination of 5 commits.
6a55ccb 
# This is the 1st commit message:

fix test for IBC

# This is the commit message #2:

[identity] Update MSAL to use its own open browser

# This is the commit message #3:

update open browser code

# This is the commit message #5:

formatting
KarishmaGhiya pushed a commit that referenced this pull request Oct 10, 2023
@mpodwysocki @KarishmaGhiya
# This is a combination of 5 commits.
d0e1727 
# This is the 1st commit message:

fix test for IBC

# This is the commit message #2:

[identity] Update MSAL to use its own open browser

# This is the commit message #3:

update open browser code

# This is the commit message #5:

formatting
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarzavery amarzavery Awaiting requested review from amarzavery

@kpajdzik kpajdzik Awaiting requested review from kpajdzik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint-124
Development

Successfully merging this pull request may close these issues.
1 participant
@RikkiGibson