Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Service Bus] Perf tests with the framework #12993
[Service Bus] Perf tests with the framework #12993
Changes from all commits
834bbf6
8978ad1
a4e2bc0
8a9dcb9
a9a19b7
bdc6374
94f41b2
16000be
105798d
58d975e
75d1bae
2d26744
c01e6cf
9616c50
7b2d768
38006be
eefe2e7
d70f1a0
334e5ef
440046d
2cee791
e34bc0c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Future concern: should we be using .tryAdd() ourselves or are we guaranteed that we'll never exceed the size of a single batch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, makes sense to use tryAdd. I'll put a follow-up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#13489
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if I get what goes in perf-js-libs vs perf/track-? Is it just archiving these files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More or less, yes.
perf-js-libs
perf-js-libs/azure-sb-package
perf-js-libs/rhea-promise
perf-js-libs/service-bus-v1
perf-js-libs/service-bus-v7
perf/track-*
perf/track-1
- v1perf/track-2
- v7Description
perf-js-libs
do not use the framework and have the tests for send, streaming receive and batch receive.perf/track-*
uses the framework for send test, and currently has the send test only.More thoughts
perf/track-*
folder itself and thus removing the need forperf-js-libs/service-bus-v*
folders.perf-js-libs/azure-sb-package
can be removed as it is pretty much outdated at the moment.perf-js-libs/rhea-promise
, which could be moved toperf/rhea-promise
after updating the send test with the framework and migrating the standalone receive tests.perf/track-1
,perf/track-2
andperf/rhea-promise
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#13489