[Service Bus] Perf tests with the framework #12993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to harshan/perf/service-bus
| @@ -10,7 +10,8 @@ | |||
| "node_modules", | |||
| "./types/**/*.d.ts", | |||
| "./samples/**/*.ts", | |||
| "test/perf/*", | |||
| "test/perf-js-libs/*", | |||
There was a problem hiding this comment.
I'm not sure if I get what goes in perf-js-libs vs perf/track-? Is it just archiving these files?
There was a problem hiding this comment.
More or less, yes.
perf-js-libs
perf-js-libs/azure-sb-packageperf-js-libs/rhea-promiseperf-js-libs/service-bus-v1perf-js-libs/service-bus-v7
perf/track-*
perf/track-1- v1perf/track-2- v7
Description
perf-js-libsdo not use the framework and have the tests for send, streaming receive and batch receive.perf/track-*uses the framework for send test, and currently has the send test only.- Since this uses the framework, it helps with comparisons across languages.
- Framework isn't capable of handling the receive tests, so they have to be standalone tests.
More thoughts
- Eventually, I intend to have the standalone tests in the
perf/track-*folder itself and thus removing the need forperf-js-libs/service-bus-v*folders. - The
perf-js-libs/azure-sb-packagecan be removed as it is pretty much outdated at the moment. - That leaves us with
perf-js-libs/rhea-promise, which could be moved toperf/rhea-promiseafter updating the send test with the framework and migrating the standalone receive tests. - Finally, we'll end up with
perf/track-1,perf/track-2andperf/rhea-promise.
mikeharder
requested changes
Jan 11, 2021
mikeharder
approved these changes
Jan 19, 2021
| await this.sender.sendMessages( | ||
| new Array(this.parsedOptions.numberOfMessages.value!).fill(this.sbMessage) | ||
| ); | ||
| await this.sender.sendMessages(this.batch); |
There was a problem hiding this comment.
Future concern: should we be using .tryAdd() ourselves or are we guaranteed that we'll never exceed the size of a single batch?
There was a problem hiding this comment.
Hmmm, makes sense to use tryAdd. I'll put a follow-up PR.
richardpark-msft
approved these changes
Jan 29, 2021
|
Hello @HarshaNalluru! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
2 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New perf folder
To execute the track 2 tests
rush build -t service-bus.service-busfoldercd sdk\servicebus\service-bus\.servicebus\service-busfolder withSERVICEBUS_CONNECTION_STRINGvariables.npm run perf-test:node -- BatchSendTest --warmup 2 --duration 7 --parallel 2To execture the track 1 tests
test-utils\perfstressfoldercd sdk\test-utils\perfstress\rush update && rush build -t test-utils-perfstressrushx packservice-bus\perf\track-1foldercd sdk\servicebus\service-bus\perf\track-1.npm i ..\..\..\..\..\test-utils\perfstress\azure-test-utils-perfstress-1.0.0.tgznpm installto getservice-bus V1.servicebus\service-busfolder withSERVICEBUS_CONNECTION_STRINGandQUEUE_NAMEvariables.npm run perf-test:node -- BatchSendTest --warmup 2 --duration 7 --parallel 2Existing perf tests
azure-sb,rhea-promise,service-bus-v1, andservice-bus-v7libraries.