Update java doc for Security modules. #25793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into yonghui/security_modules_java_doc
2 tasks
chenrujun
suggested changes
Dec 7, 2021
...zure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultEncode.java
Outdated
Show resolved
Hide resolved
...zure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultEncode.java
Outdated
Show resolved
Hide resolved
...zure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultEncode.java
Outdated
Show resolved
Hide resolved
...zure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultEncode.java
Outdated
Show resolved
Hide resolved
...zure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultEncode.java
Outdated
Show resolved
Hide resolved
...a/com/azure/spring/cloud/autoconfigure/aad/webapp/AADOAuth2AuthorizationRequestResolver.java
Outdated
Show resolved
Hide resolved
...gure/src/main/java/com/azure/spring/cloud/autoconfigure/aad/webapp/AADOAuth2UserService.java
Outdated
Show resolved
Hide resolved
...ain/java/com/azure/spring/cloud/autoconfigure/aad/webapp/AADWebApplicationConfiguration.java
Outdated
Show resolved
Hide resolved
...in/java/com/azure/spring/cloud/autoconfigure/aad/webapp/AADWebSecurityConfigurerAdapter.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/com/azure/spring/cloud/autoconfigure/aad/webapp/AzureClientRegistration.java
Outdated
Show resolved
Hide resolved
chenrujun
suggested changes
Dec 8, 2021
| * @param bytes signature obtained | ||
| * @param offset the offset in the byte array | ||
| * @param length the number of bytes to convert | ||
| * @return decoded signatures |
There was a problem hiding this comment.
@return The byte array which holds the big integer.
| @@ -258,16 +332,35 @@ public Key engineGetKey(String alias, char[] password) { | |||
| .orElse(null); | |||
| } | |||
|
|
|||
| /** | |||
| * Get the entry identified by the given alias. | |||
There was a problem hiding this comment.
Check whether the entry identified by the given alias contains a trusted certificate.
| @Override | ||
| public boolean engineIsCertificateEntry(String alias) { | ||
| return getAllAliases().contains(alias); | ||
| } | ||
|
|
||
| /** | ||
| * Get the entry identified by the given alias. |
There was a problem hiding this comment.
Check whether the entry identified by the given alias is a key-related.
|
Hi, @hui1110 , please resolve the conflicts. |
chenrujun
suggested changes
Dec 8, 2021
| @@ -57,6 +58,13 @@ public AADAppRoleStatelessAuthenticationFilter(UserPrincipalManager principalMan | |||
| this.principalManager = principalManager; | |||
| } | |||
|
|
|||
| /** | |||
| * Set internal filter. | |||
| @@ -117,6 +118,13 @@ public AADAuthenticationFilter(AADAuthenticationProperties aadAuthenticationProp | |||
| ); | |||
| } | |||
|
|
|||
| /** | |||
| * Set internal filter. | |||
|
|
||
| /** | ||
| * Provides HttpServletRequest and HttpServletResponse arguments instead of the | ||
| * default ServletRequest and ServletResponse ones. |
…re-sdk-for-java into yonghui/security_modules_java_doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All classes out of "implementation" package.
TODO