Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve java doc's quality for Security modules #24412

Closed
2 tasks
Tracked by #24332
, #23402
...
chenrujun opened this issue Sep 28, 2021 · 3 comments · Fixed by #25793
Closed
2 tasks
Tracked by #24332
, #23402
...

Improve java doc's quality for Security modules #24412

chenrujun opened this issue Sep 28, 2021 · 3 comments · Fixed by #25793
Assignees
@hui1110
Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Milestone
Spring Cloud Azur...

Comments

@chenrujun
Copy link

chenrujun commented Sep 28, 2021 •
edited
Loading

Parent issue: #24332

  • azure-security-keyvault-jca. All classes out of "implementation" package.
  • spring-cloud-azure-autoconfigure, All classes under com.azure.spring.cloud.autoconfigure.aad package and out of "implementation" package.
@chenrujun chenrujun added Client This issue points to a problem in the data-plane of the library. azure-spring All azure-spring related issues labels Sep 28, 2021
@chenrujun chenrujun self-assigned this Sep 28, 2021
@chenrujun chenrujun added this to the [2021] December milestone Sep 28, 2021
This was referenced Sep 28, 2021
Closed
Closed
@chenrujun
Copy link
Author

Closing this issue because we will not release spring-security-azure-oauth2-client any more.

@chenrujun
Copy link
Author

Reopen this issue because:

  1. AAD related logic added into 4.0 version.
  2. KeyVault secret belongs to this scope.

@chenrujun chenrujun reopened this Nov 24, 2021
@chenrujun chenrujun assigned hui1110 and unassigned chenrujun Dec 1, 2021
@hui1110 hui1110 moved this to Todo in Spring Cloud Azure Dec 1, 2021
@hui1110 hui1110 moved this from Todo to In Progress in Spring Cloud Azure Dec 1, 2021
@hui1110 hui1110 linked a pull request Dec 6, 2021 that will close this issue
Update java doc for Security modules. #25793
Merged
2 tasks
@hui1110 hui1110 moved this from In Progress to Done in Spring Cloud Azure Dec 10, 2021
@hui1110
Copy link
Contributor

hui1110 commented Dec 10, 2021

The pr to fix the issue has been merged.

@hui1110 hui1110 closed this as completed Dec 10, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hui1110 hui1110

Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Projects
Spring Cloud Azure
Archived in project
Milestone
Spring Cloud Azure 4.0 Beta3
Development

Successfully merging a pull request may close this issue.

Update java doc for Security modules.
3 participants
@chenrujun @saragluna @hui1110