Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent Pom: remove same version for resourcemanager #15311

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Parent Pom: remove same version for resourcemanager #15311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions sdk/parents/azure-client-sdk-parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,11 +491,6 @@
This rule is used to enforce that all modules depend on the same version of particular dependencies or
plugins.
-->
<requireSameVersions>
<dependencies>
<dependency>com.azure.*</dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be changed to com.azure:* instead of being removed?

Copy link
Contributor Author

@ChenTanyi ChenTanyi Sep 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what you really want to do for such SameVersions.
As I tested, if I add com.azure:*, all data-plane SDK will build with failure, since all their versions are different

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like: https://github.com/Azure/azure-sdk-for-java/blob/10bf934/sdk/storage/azure-storage-blob/pom.xml#L55-L69

</dependencies>
</requireSameVersions>
</rules>
<fail>true</fail>
</configuration>
Expand Down