Parent Pom: remove same version for resourcemanager #15311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -491,11 +491,6 @@ | |||
| This rule is used to enforce that all modules depend on the same version of particular dependencies or | |||
| plugins. | |||
| --> | |||
| <requireSameVersions> | |||
| <dependencies> | |||
| <dependency>com.azure.*</dependency> | |||
There was a problem hiding this comment.
Should this be changed to com.azure:* instead of being removed?
There was a problem hiding this comment.
I don't know what you really want to do for such SameVersions.
As I tested, if I add com.azure:*, all data-plane SDK will build with failure, since all their versions are different
There was a problem hiding this comment.
weidongxu-microsoft
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
com.azure.*only affectcom.azure.resourcemanagerwhile others arecom.azure:*. But we don't want to stay every dependency in same version, so remove it.