{AzureSubscription} Fixes Azure/azure-sdk-for-go#18619

[navba-MSFT]

Fixes #18619

The TenantIDDescription struct returned by calls to TenantsClient.ListComplete contains only two fields: ID and TenantID:

However, the underlying API returns many more useful fields, including countryCode, displayName, domains, tenantCategory defaultDomain and tenantType. It would be great if these fields could also be made accessible through the Go SDK.

• The purpose of this PR is explained in this or a referenced issue.
• The PR does not update generated files.
  • These files are managed by the codegen framework at Azure/autorest.go.
• Tests are included and/or updated for code changes.
• Updates to CHANGELOG.md are included.
• MIT license headers are included in each file.

[hermanschaaf]

Hi @navba-MSFT, thanks again for championing this change. I just wanted to note that I believe this is similar to the subscription case, in that the file here is generated from an underlying JSON source, so it will need to be updated at the source first.

[chlowell]

This file is generated. If it needs an update, we should regenerate the package rather than edit its files manually. The code here is correct though. It was generated for a REST API whose TenantIdDescription model has only two fields, as you can see in its specification here (sorry I don't know where this API is found in the REST docs). The SDK package corresponding to the REST API mentioned in the linked issue is services/resources/mgmt/2021-01-01/subscriptions. However, that package is deprecated, so I recommend using the new armsubscriptions module instead.

This is a confusing couple of packages/APIs. Can another reviewer comment on why we have armsubscription and armsubscriptions packages?

[tadelesh]

@navba-MSFT As explanation in this PR, I'll close this PR. Thanks @chlowell to help to explain the deprecation of the package. I'll check these two subscription packages.