Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ARMSubscription) fixes Azure/azure-sdk-for-go#18620 #18666

Closed
wants to merge 1 commit into from

Conversation

navba-MSFT
Copy link

@navba-MSFT navba-MSFT commented Jul 21, 2022

fixes #18620

The subscriptions Model struct includes a number of fields, but not all the fields available in the REST API according to the documentation. Specifically, the following fields are missing in the Go struct:

tenantId - The subscription tenant ID.
tags - The tags attached to the subscription.

Note that these fields are returned by the API and are documented here: https://docs.microsoft.com/en-us/rest/api/resources/subscriptions/list?tabs=HTTP#subscription

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

fixes #18620

The subscriptions Model struct includes a number of fields, but not all the fields available in the REST API according to the documentation. Specifically, the following fields are missing in the Go struct:

tenantId - The subscription tenant ID.
tags - The tags attached to the subscription.

Note that these fields are returned by the API and are documented here: https://docs.microsoft.com/en-us/rest/api/resources/subscriptions/list?tabs=HTTP#subscription
@hermanschaaf
Copy link

@navba-MSFT Thank you for looking into this issue 🙇

I'm not super familiar with this repo, but as far as I can tell, the fix will need to be in the underlying OpenAPI JSON spec first, and then the code here should be regerenated. As it stands, it looks like this PR's change will be lost the next time the code is regenerated.

@navba-MSFT
Copy link
Author

@navba-MSFT Thank you for looking into this issue 🙇

I'm not super familiar with this repo, but as far as I can tell, the fix will need to be in the underlying OpenAPI JSON spec first, and then the code here should be regerenated. As it stands, it looks like this PR's change will be lost the next time the code is regenerated.

@hermanschaaf You are right. I have created another PR in the RestAPi specs repo:
Azure/azure-rest-api-specs#19870

@tadelesh
Copy link
Member

@navba-MSFT We do not change the SDK manually. This PR will be closed and after the swagger updated, we will release the new SDK according to service team's release request.

@tadelesh tadelesh closed this Jul 22, 2022
@RickWinter RickWinter deleted the navba-MSFT-patch-1 branch March 15, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscriptions List should include all the fields available in the API
3 participants