Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CI file #14946

Merged
merged 2 commits into from
Jun 30, 2021
Merged

Adding CI file #14946

merged 2 commits into from
Jun 30, 2021

Conversation

mohsha-msft
Copy link
Contributor

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Jun 30, 2021
@check-enforcer
Copy link

This repository is protected by Check Enforcer. The check-enforcer check-run will not pass until there is at least one more check-run successfully passing. Check Enforcer supports the following comment commands:

  • /check-enforcer evaluate; tells Check Enforcer to evaluate this pull request.
  • /check-enforcer override; by-pass Check Enforcer (approvals still required).



stages:
- template: ../../eng/pipelines/templates/jobs/archetype-sdk-client.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure Pipelines supports "absolute" pathing with template paths that correspond to the repo root. I prefer that approach since it prevents relative pathing issues (which you have here, since you are actually one directory deeper than the ci.yml file I assume this was copied over from).

Suggested change
- template: ../../eng/pipelines/templates/jobs/archetype-sdk-client.yml
- template: /eng/pipelines/templates/jobs/archetype-sdk-client.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh I see. I noticed similar changes in https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azcore/ci.yml where CI is already running so I decided to give it a try. Let me change that and get back to you.

@benbp
Copy link
Member

benbp commented Jun 30, 2021

/azp run prepare-pipelines

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@benbp
Copy link
Member

benbp commented Jun 30, 2021

We'll need #14947 to go in before we can generate the pipeline for this PR.

@mohsha-msft
Copy link
Contributor Author

We'll need #14947 to go in before we can generate the pipeline for this PR.

Ohh I see. Great. I can see it has finished working @benbp

@mohsha-msft mohsha-msft merged commit f2a6ec1 into track2-storage Jun 30, 2021
@mohsha-msft mohsha-msft deleted the mohsha-msft/making-ci-work branch June 30, 2021 20:32
@mohsha-msft
Copy link
Contributor Author

mohsha-msft commented Jun 30, 2021

FYI @zezha-msft @nakulkar-msft I'm merging the branch directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants