Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CI file #14946

Merged
merged 2 commits into from
Jun 30, 2021
Merged

Adding CI file #14946

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc2eda6
Adding CI file
mohsha-msft Jun 30, 2021
ee7b765
Updates template file path from relative to absolute
mohsha-msft Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions sdk/storage/azblob/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
trigger:
paths:
include:
- sdk/storage/azblob

pr:
paths:
include:
- sdk/storage/azblob


stages:
- template: ../../eng/pipelines/templates/jobs/archetype-sdk-client.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure Pipelines supports "absolute" pathing with template paths that correspond to the repo root. I prefer that approach since it prevents relative pathing issues (which you have here, since you are actually one directory deeper than the ci.yml file I assume this was copied over from).

Suggested change
- template: ../../eng/pipelines/templates/jobs/archetype-sdk-client.yml
- template: /eng/pipelines/templates/jobs/archetype-sdk-client.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh I see. I noticed similar changes in https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azcore/ci.yml where CI is already running so I decided to give it a try. Let me change that and get back to you.

parameters:
ServiceDirectory: 'azblob'