Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nextLink for list container request. #5562

Merged
merged 2 commits into from
May 6, 2019
+28 −3
Merged

Support nextLink for list container request. #5562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc64ac5
Add nextLink in list container response; support $prefix, $maxpagesiz…
huizlAzure Apr 2, 2019
58a6ac7
Addressing CR comment: mark next-link as readOnly
huizlAzure Apr 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions specification/storage/resource-manager/Microsoft.Storage/stable/2019-04-01/blob.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,24 @@
},
{
"$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/SubscriptionIdParameter"
},
{
"name": "$skipToken",
"in": "query",
"type": "string",
"description": "Optional. Continuation token for the list operation."
},
{
"name": "$maxpagesize",
"in": "query",
"type": "string",
"description": "Optional. Specified maximum number of containers that can be included in the list."
},
{
"name": "$filter",
"in": "query",
"type": "string",
"description": "Optional. When specified, only container names starting with the filter will be listed."
}
],
"responses": {
Expand Down Expand Up @@ -1004,10 +1022,16 @@
"items": {
"$ref": "#/definitions/ListContainerItem"
},
"description": "The list of blob containers."
"description": "List of blobs containers returned.",
"readOnly": true
},
"nextLink": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mark this as readonly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed. Thanks for the comment!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huizlAzure did you push a new commit, I don't see any changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes just did. I squashed the commits maybe that's why.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nextLink must be marked as readonly

"type": "string",
"description": "Request URL that can be used to query next page of containers. Returned when total number of requested containers exceed maximum page size.",
"readOnly": true
}
},
"description": "The list of blob containers."
"description": "Response schema. Contains list of blobs returned, and if paging is requested or required, a URL to next page of containers."
},
"BlobServiceProperties": {
"properties": {
Expand Down
3 changes: 2 additions & 1 deletion ...age/resource-manager/Microsoft.Storage/stable/2019-04-01/examples/BlobContainersList.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@
"hasLegalHold": false
}
}
]
],
"nextLink": "https://sto1590endpoint/subscriptions/{subscription-id}/resourceGroups/res9290/providers/Microsoft.Storage/storageAccounts/sto1590/blobServices/default/containers?api-version=2019-04-01&$maxpagesize=2&$skipToken=/sto1590/container5103"
}
}
}
Expand Down