Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support nextLink for list container request. #5562

Merged
merged 2 commits into from
May 6, 2019
Merged

Support nextLink for list container request. #5562

merged 2 commits into from
May 6, 2019

Conversation

huizlAzure
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI AutorestCI mentioned this pull request Apr 5, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Apr 5, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#2724

@azuresdkci azuresdkci requested a review from dsgouda April 5, 2019 21:04
@AutorestCI
Copy link

AutorestCI commented Apr 5, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#5088

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Apr 5, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Apr 5, 2019 •
edited
Loading

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#3098

@AutorestCI
Copy link

AutorestCI commented Apr 5, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4701

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 5, 2019
@adxsdknet
.NET SDK Resource Provider:'Storage'
6fee538 
REST Spec PR 'Azure/azure-rest-api-specs#5562'
REST Spec PR Author 'huizlAzure'
REST Spec PR Last commit
@adxsdknet
Copy link

adxsdknet commented Apr 5, 2019 •
edited
Loading

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5723
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@6fee538
adxsdknet/azure-sdk-for-net@c2ddf1a
adxsdknet/azure-sdk-for-net@aa48d87

dsgouda
dsgouda suggested changes Apr 5, 2019
View reviewed changes
specification/storage/resource-manager/Microsoft.Storage/stable/2019-04-01/blob.json
"description": "The list of blob containers."
"description": "List of blobs containers returned."
},
"nextLink": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mark this as readonly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed. Thanks for the comment!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huizlAzure did you push a new commit, I don't see any changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes just did. I squashed the commits maybe that's why.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nextLink must be marked as readonly

@huizlAzure huizlAzure force-pushed the list_container_next_link branch 2 times, most recently from 801181f to c1a735c Compare April 25, 2019 17:48
@huizlAzure huizlAzure force-pushed the list_container_next_link branch from c1a735c to cc64ac5 Compare April 25, 2019 18:08
This was referenced Apr 25, 2019
Closed
Closed
adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 25, 2019
@adxsdknet
.NET SDK Resource Provider:'Storage'
c2ddf1a 
REST Spec PR 'Azure/azure-rest-api-specs#5562'
REST Spec PR Author 'huizlAzure'
REST Spec PR Last commit
This was referenced Apr 30, 2019
Closed
Closed
Merged
adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 30, 2019
@adxsdknet
.NET SDK Resource Provider:'Storage'
aa48d87 
REST Spec PR 'Azure/azure-rest-api-specs#5562'
REST Spec PR Author 'huizlAzure'
REST Spec PR Last commit
dsgouda
dsgouda approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 9cfc970 into Azure:master May 6, 2019
dsgouda pushed a commit to Azure/azure-sdk-for-net that referenced this pull request May 6, 2019
@adxsdknet @dsgouda
AutoPr-Storage-huizlAzure-REST Spec PrNumber 5562 (#5723)
583fd10 
* .NET SDK Resource Provider:'Storage'
REST Spec PR 'Azure/azure-rest-api-specs#5562'
REST Spec PR Author 'huizlAzure'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Storage'
REST Spec PR 'Azure/azure-rest-api-specs#5562'
REST Spec PR Author 'huizlAzure'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Storage'
REST Spec PR 'Azure/azure-rest-api-specs#5562'
REST Spec PR Author 'huizlAzure'
REST Spec PR Last commit
This was referenced May 6, 2019
Merged
Merged
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@adxsdknet @mentat9
AutoPr-Storage-huizlAzure-REST Spec PrNumber 5562 (Azure#5723)
a334fac 
* .NET SDK Resource Provider:'Storage'
REST Spec PR 'Azure/azure-rest-api-specs#5562'
REST Spec PR Author 'huizlAzure'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Storage'
REST Spec PR 'Azure/azure-rest-api-specs#5562'
REST Spec PR Author 'huizlAzure'
REST Spec PR Last commit

* .NET SDK Resource Provider:'Storage'
REST Spec PR 'Azure/azure-rest-api-specs#5562'
REST Spec PR Author 'huizlAzure'
REST Spec PR Last commit
@lmazuel lmazuel mentioned this pull request Jun 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees

@dsgouda dsgouda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@huizlAzure @AutorestCI @azuresdkci @adxsdknet @dsgouda