Jsedlak microsoft languages #25933
Merged
Jsedlak microsoft languages #25933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| geocoding.json | 2021-11-01-preview(3315b65) | 2021-11-01-preview(main) |
| geocoding.json | 2022-02-01-preview(3315b65) | 2022-02-01-preview(main) |
| search.json | 2022-09-01-preview(3315b65) | 2022-09-01-preview(main) |
| search.json | 2022-12-01-preview(3315b65) | 2022-12-01-preview(main) |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.5) | new version | base version |
|---|---|---|
| 2021-11-01-preview | 2021-11-01-preview(3315b65) | 2021-11-01-preview(main) |
| 2022-02-01-preview | 2022-02-01-preview(3315b65) | 2022-02-01-preview(main) |
| package-preview-2022-09 | package-preview-2022-09(3315b65) | package-preview-2022-09(main) |
| package-preview-2022-12 | package-preview-2022-12(3315b65) | package-preview-2022-12(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The integer type does not have a format, please add it. Location: Search/preview/2021-11-01-preview/geocoding.json#L54 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Search/preview/2021-11-01-preview/geocoding.json#L310 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Search/preview/2021-11-01-preview/geocoding.json#L339 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Search/preview/2021-11-01-preview/geocoding.json#L355 |
|
The integer type does not have a format, please add it. Location: Search/preview/2021-11-01-preview/geocoding.json#L383 |
|
The integer type does not have a format, please add it. Location: Search/preview/2021-11-01-preview/geocoding.json#L513 |
|
The integer type does not have a format, please add it. Location: Search/preview/2021-11-01-preview/geocoding.json#L518 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Search/preview/2021-11-01-preview/geocoding.json#L543 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Search/preview/2021-11-01-preview/geocoding.json#L665 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Search/preview/2021-11-01-preview/geocoding.json#L674 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Search/preview/2021-11-01-preview/geocoding.json#L687 |
|
The integer type does not have a format, please add it. Location: Search/preview/2022-02-01-preview/geocoding.json#L54 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Search/preview/2022-02-01-preview/geocoding.json#L358 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Search/preview/2022-02-01-preview/geocoding.json#L374 |
|
The integer type does not have a format, please add it. Location: Search/preview/2022-02-01-preview/geocoding.json#L402 |
|
The integer type does not have a format, please add it. Location: Search/preview/2022-02-01-preview/geocoding.json#L532 |
|
The integer type does not have a format, please add it. Location: Search/preview/2022-02-01-preview/geocoding.json#L537 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Search/preview/2022-02-01-preview/geocoding.json#L693 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Search/preview/2022-02-01-preview/geocoding.json#L702 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Location: Search/preview/2022-02-01-preview/geocoding.json#L715 |
| Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Search/preview/2021-11-01-preview/geocoding.json#L126 |
|
| A required parameter should not specify a default value. Location: Search/preview/2021-11-01-preview/geocoding.json#L144 |
|
| Error response should contain a x-ms-error-code header. Location: Search/preview/2021-11-01-preview/geocoding.json#L250 |
|
The error property in the error response schema should be required.Location: Search/preview/2021-11-01-preview/geocoding.json#L250 |
|
Error schema should define code and message properties as required.Location: Search/preview/2021-11-01-preview/geocoding.json#L250 |
|
| Operation might be pageable. Consider adding the x-ms-pageable extension. Location: Search/preview/2021-11-01-preview/geocoding.json#L257 |
|
| A required parameter should not specify a default value. Location: Search/preview/2021-11-01-preview/geocoding.json#L269 |
|
| Schema with type: integer should specify format Location: Search/preview/2021-11-01-preview/geocoding.json#L288 |
|
| Schema with type: integer should specify format Location: Search/preview/2021-11-01-preview/geocoding.json#L288 |
|
| Schema with type: integer should specify format Location: Search/preview/2021-11-01-preview/geocoding.json#L294 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
Generated ApiView
|
specification/maps/data-plane/Search/preview/2021-11-01-preview/geocoding.json
Outdated
Show resolved
Hide resolved
weidongxu-microsoft
approved these changes
Sep 27, 2023
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Update search 2021-11-01-preview language coverage link * Update 2022-02-01-preview supported language link * Update 2022-09-01-preview supported languages link * Update 2022-12-01-preview supported languages link * Remove locale * Update geocoding.json to remove locale in URL * Update geocoding.json to remove locale in URL * Update search.json to remove locale in URL * Update search.json to remove locale in URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API - Pull Request
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links