-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API changes for Provider Ports #18484
Closed
Closed
Changes from 19 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
26d185a
Update expressRouteCrossConnection.json
jashsing-mic e003b3d
Update expressRouteCrossConnection.json
jashsing-mic 8603f6a
Create expressRouteProviderPort.json
jashsing-mic 9a1cafa
Create expressRouteProviderPort.json
jashsing-mic f1c6137
Create expressRouteProviderPortList.json
jashsing-mic 2c32549
Create expressRouteProviderPortLocationList.json
jashsing-mic 575e44c
Delete expressRouteProviderPort.json
jashsing-mic b6480df
Update expressRouteProviderPort.json
jashsing-mic 37c91d0
Create expressRouteProviderPort.json
jashsing-mic 10a9fcf
Create expressRouteProviderPortList.json
jashsing-mic eb8290c
Create expressRouteProviderPortLocationList.json
jashsing-mic 903edb9
Delete expressRouteProviderPort.json
jashsing-mic 21af2ee
Delete expressRouteProviderPortList.json
jashsing-mic bf4c3de
Delete expressRouteProviderPortLocationList.json
jashsing-mic 20afa0e
Update expressRouteProviderPort.json
jashsing-mic 30c25e5
Update expressRouteCrossConnection.json
jashsing-mic 857af93
Update expressRouteProviderPort.json
jashsing-mic 5acdad4
Create expressRouteProviderPort.json
jashsing-mic 4e83b60
Delete expressRouteProviderPort.json
jashsing-mic e6eaaa4
Update expressRouteProviderPortList.json
jashsing-mic 5ee38f4
Update expressRouteProviderPortLocationList.json
jashsing-mic 85822dc
Update readme.md
jashsing-mic 26277c5
Update expressRouteProviderPort.json
jashsing-mic da77583
Update readme.md
jashsing-mic 1bd5bc8
Update expressRouteProviderPort.json
jashsing-mic e96af52
Update readme.md
jashsing-mic 17fc3ab
Rename expressRouteProviderPortLocationList.json to expressRouteProvi…
jashsing-mic f23f08a
Update expressRouteProviderPort.json
jashsing-mic b370868
Update expressRouteProviderPort.json
jashsing-mic 190132c
Update expressRouteProviderPort.json
jashsing-mic 90efc51
Update custom-words.txt
jashsing-mic 63fc1c2
Update expressRouteProviderPort.json
jashsing-mic 22f5971
Update expressRouteProviderPort.json
jashsing-mic a2f9dcd
Update expressRouteProviderPortList.json
jashsing-mic 5b654b4
Update expressRouteProviderPort.json
jashsing-mic 7a32c9d
Update expressRouteProviderPort.json
jashsing-mic 5090b33
Update expressRouteProviderPort.json
jashsing-mic 91d7589
Update expressRouteProviderPort.json
jashsing-mic 4d1f3de
Update expressRouteProviderPort.json
jashsing-mic e18bd11
Update expressRouteProviderPort.json
jashsing-mic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
49 changes: 49 additions & 0 deletions
49
...ce-manager/Microsoft.Network/stable/2021-08-01/examples/expressRouteProviderPortList.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
{ | ||
"parameters": { | ||
"api-version": "2021-08-01", | ||
"subscriptionId": "subid" | ||
}, | ||
"responses": { | ||
"200": { | ||
"body": { | ||
"value": [ | ||
{ | ||
"portPairDescriptor": "bvtazureixpportpair1", | ||
"id": "/subscriptions/subid/providers/Microsoft.Network/ExpressRoutePortsLocations/SiliconValley/bvtazureixpportpair1", | ||
"type": "Microsoft.Network/expressRouteProviderPort", | ||
"location": "uswest", | ||
"etag": "W/\"c0e6477e-8150-4d4f-9bf6-bb10e6acb63a\"", | ||
"properties": { | ||
"portPairDescriptor": "bvtazureixpportpair", | ||
"primaryAzurePort": "bvtazureixp01", | ||
"secondaryAzurePort": "bvtazureixp01", | ||
"peeringLocation": "SiliconValley", | ||
"overprovisionFactor": 4, | ||
"portBandwidthInMbps": 4000, | ||
"usedBandwidthInMbps": 2500, | ||
"remainingBandwidthInMbps": 1500 | ||
} | ||
}, | ||
{ | ||
"portPairDescriptor": "bvtazureixpportpair2", | ||
"id": "/subscriptions/subid/providers/Microsoft.Network/ExpressRoutePortsLocations/SiliconValley/bvtazureixpportpair2", | ||
"type": "Microsoft.Network/expressRouteProviderPort", | ||
"location": "uswest", | ||
"etag": "W/\"c0e6477e-8150-4d4f-9bf6-bb10e6acb63a\"", | ||
"properties": { | ||
"portPairDescriptor": "bvtazureixpportpair2", | ||
"primaryAzurePort": "bvtazureixp02", | ||
"secondaryAzurePort": "bvtazureixp02", | ||
"peeringLocation": "seattle", | ||
"overprovisionFactor": 4, | ||
"portBandwidthInMbps": 4000, | ||
"usedBandwidthInMbps": 1200, | ||
"remainingBandwidthInMbps": 1800 | ||
} | ||
} | ||
] | ||
} | ||
} | ||
} | ||
} | ||
|
33 changes: 33 additions & 0 deletions
33
...er/Microsoft.Network/stable/2021-08-01/examples/expressRouteProviderPortLocationList.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
{ | ||
"parameters": { | ||
"api-version": "2021-08-01", | ||
"locationName": "SiliconValley", | ||
"subscriptionId": "subid" | ||
}, | ||
"responses": { | ||
"200": { | ||
"body": { | ||
"value": [ | ||
{ | ||
"portPairDescriptor": "bvtazureixpportpair1", | ||
"id": "/subscriptions/subid/providers/Microsoft.Network/ExpressRoutePortsLocations/SiliconValley/bvtazureixpportpair1", | ||
"type": "Microsoft.Network/expressRouteProviderPort", | ||
"location": "uswest", | ||
"etag": "W/\"c0e6477e-8150-4d4f-9bf6-bb10e6acb63a\"", | ||
"properties": { | ||
"portPairDescriptor": "bvtazureixpportpair", | ||
"primaryAzurePort": "bvtazureixp01", | ||
"secondaryAzurePort": "bvtazureixp01", | ||
"peeringLocation": "SiliconValley", | ||
"overprovisionFactor": 4, | ||
"portBandwidthInMbps": 4000, | ||
"usedBandwidthInMbps": 2500, | ||
"remainingBandwidthInMbps": 1500 | ||
} | ||
} | ||
] | ||
} | ||
} | ||
} | ||
} | ||
|
206 changes: 206 additions & 0 deletions
206
...etwork/resource-manager/Microsoft.Network/stable/2021-08-01/expressRouteProviderPort.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,206 @@ | ||
{ | ||
"swagger": "2.0", | ||
"info": { | ||
"title": "NetworkManagementClient", | ||
"description": "The Microsoft Azure Network management API provides a RESTful set of web services that interact with Microsoft Azure Networks service to manage your network resources. The API has entities that capture the relationship between an end user and the Microsoft Azure Networks service.", | ||
"version": "2021-08-01" | ||
}, | ||
"host": "management.azure.com", | ||
"schemes": [ | ||
"https" | ||
], | ||
"consumes": [ | ||
"application/json" | ||
], | ||
"produces": [ | ||
"application/json" | ||
], | ||
"security": [ | ||
{ | ||
"azure_auth": [ | ||
"user_impersonation" | ||
] | ||
} | ||
], | ||
"securityDefinitions": { | ||
"azure_auth": { | ||
"type": "oauth2", | ||
"authorizationUrl": "https://login.microsoftonline.com/common/oauth2/authorize", | ||
"flow": "implicit", | ||
"description": "Azure Active Directory OAuth2 Flow.", | ||
"scopes": { | ||
"user_impersonation": "impersonate your user account" | ||
} | ||
} | ||
}, | ||
"paths": { | ||
"/subscriptions/{subscriptionId}/providers/Microsoft.Network/expressRouteProviderPorts": { | ||
"get": { | ||
"tags": [ | ||
"ExpressRouteProviderPorts" | ||
], | ||
"operationId": "ExpressRouteProviderPortsLocation_List", | ||
"description": "Retrieves all the ExpressRouteProviderPorts in a subscription.", | ||
"parameters": [ | ||
{ | ||
"$ref": "./network.json#/parameters/ApiVersionParameter" | ||
}, | ||
{ | ||
"$ref": "./network.json#/parameters/SubscriptionIdParameter" | ||
}, | ||
{ | ||
"name": "$filter", | ||
"in": "query", | ||
"required": false, | ||
"type": "string", | ||
"description": "The filter to apply on the operation. For example, you can use $filter=location eq '{state}'." | ||
}, | ||
], | ||
"responses": { | ||
"200": { | ||
"description": "Request successful. The operation returns a list of ExpressRouteProviderPort resources at a location. If there are no ports for the provider, an empty list is returned.", | ||
"schema": { | ||
"$ref": "#/definitions/ExpressRouteProviderPortListResult" | ||
} | ||
}, | ||
"default": { | ||
"description": "Error response describing why the operation failed.", | ||
"schema": { | ||
"$ref": "./network.json#/definitions/CloudError" | ||
} | ||
} | ||
}, | ||
"x-ms-examples": { | ||
"ExpressRouteProviderPortList": { | ||
"$ref": "./examples/ExpressRouteProviderPortList.json" | ||
}, | ||
"ExpressRouteProviderPortList": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you use different name instead of duplicated name? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
"$ref": "./examples/ExpressRouteProviderPortLocationList.json" | ||
}, | ||
} | ||
} | ||
}, | ||
"/subscriptions/{subscriptionId}/providers/Microsoft.Network/expressRouteProviderPorts/{providerport}": { | ||
"get": { | ||
"tags": [ | ||
"ExpressRouteProviderPorts" | ||
], | ||
"operationId": "ExpressRouteProviderPort", | ||
"description": "Retrieves detail of a provider port.", | ||
"parameters": [ | ||
{ | ||
"$ref": "./network.json#/parameters/ApiVersionParameter" | ||
}, | ||
{ | ||
"$ref": "./network.json#/parameters/SubscriptionIdParameter" | ||
}, | ||
{ | ||
"$ref": "./network.json#/parameters/ProviderPortParameter" | ||
}, | ||
], | ||
"responses": { | ||
"200": { | ||
"description": "Request successful. The operation returns detail of individual provider port resources. If there is no port, an empty result is returned.", | ||
"schema": { | ||
"$ref": "#/definitions/ExpressRouteProviderPort" | ||
} | ||
}, | ||
"default": { | ||
"description": "Error response describing why the operation failed.", | ||
"schema": { | ||
"$ref": "./network.json#/definitions/CloudError" | ||
} | ||
} | ||
}, | ||
"x-ms-examples": { | ||
"ExpressRouteProviderPort": { | ||
"$ref": "./examples/ExpressRouteProviderPort.json" | ||
} | ||
} | ||
} | ||
}, | ||
}, | ||
"definitions": { | ||
"ExpressRouteProviderPortProperties": { | ||
"properties": { | ||
"portPairDescriptor": { | ||
"readOnly": true, | ||
"type": "string", | ||
"description": "The name of the port pair." | ||
}, | ||
"primaryAzurePort": { | ||
"readOnly": true, | ||
"type": "string", | ||
"description": "The name of the primary port." | ||
}, | ||
"secondaryAzurePort": { | ||
"readOnly": true, | ||
"type": "string", | ||
"description": "The name of the secondary port." | ||
}, | ||
"peeringLocation": { | ||
"type": "string", | ||
"description": "The peering location of the port pair." | ||
}, | ||
"overprovisionFactor": { | ||
"type": "integer", | ||
"format": "int32", | ||
"description": "Overprovisioning factor for the port pair." | ||
}, | ||
"portBandwidthInMbps": { | ||
"type": "integer", | ||
"format": "int32", | ||
"description": "Bandwidth of the port in Mbps" | ||
}, | ||
"usedBandwidthInMbps": { | ||
"type": "integer", | ||
"format": "int32", | ||
"description": "Used Bandwidth of the port in Mbps" | ||
}, | ||
"remainingBandwidthInMbps": { | ||
"type": "integer", | ||
"format": "int32", | ||
"description": "Remaining Bandwidth of the port in Mbps" | ||
} | ||
}, | ||
"description": "Properties of ExpressRouteProviderPort." | ||
}, | ||
"ExpressRouteProviderPort": { | ||
"properties": { | ||
"properties": { | ||
"x-ms-client-flatten": true, | ||
"$ref": "#/definitions/ExpressRouteProviderPortProperties", | ||
"description": "Properties of the express route Service Provider Port." | ||
}, | ||
"etag": { | ||
"readOnly": true, | ||
"type": "string", | ||
"description": "A unique read-only string that changes whenever the resource is updated." | ||
} | ||
}, | ||
"allOf": [ | ||
{ | ||
"$ref": "./network.json#/definitions/Resource" | ||
} | ||
], | ||
"description": "ExpressRouteProviderPort resource." | ||
}, | ||
"ExpressRouteProviderPortListResult": { | ||
"properties": { | ||
"value": { | ||
"type": "array", | ||
"items": { | ||
"$ref": "#/definitions/ExpressRouteProviderPort" | ||
}, | ||
"description": "A list of ExpressRouteProviderPort resources." | ||
}, | ||
"nextLink": { | ||
"readOnly": true, | ||
"type": "string", | ||
"description": "The URL to get the next set of results." | ||
} | ||
}, | ||
"description": "Response for ListExpressRouteProviderPort API service call." | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid, according to your definition this is part of your "properties" bag. There's a well known set of top level properties (e.g. id, type), cannot add another arbitrary top-level property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix in your examples please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done