Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API changes for Provider Ports #18484

Closed
wants to merge 40 commits into from
Closed
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
26d185a
Update expressRouteCrossConnection.json
jashsing-mic Mar 30, 2022
e003b3d
Update expressRouteCrossConnection.json
jashsing-mic Mar 30, 2022
8603f6a
Create expressRouteProviderPort.json
jashsing-mic Mar 30, 2022
9a1cafa
Create expressRouteProviderPort.json
jashsing-mic Mar 30, 2022
f1c6137
Create expressRouteProviderPortList.json
jashsing-mic Mar 30, 2022
2c32549
Create expressRouteProviderPortLocationList.json
jashsing-mic Mar 30, 2022
575e44c
Delete expressRouteProviderPort.json
jashsing-mic Mar 30, 2022
b6480df
Update expressRouteProviderPort.json
jashsing-mic Apr 1, 2022
37c91d0
Create expressRouteProviderPort.json
jashsing-mic Apr 1, 2022
10a9fcf
Create expressRouteProviderPortList.json
jashsing-mic Apr 1, 2022
eb8290c
Create expressRouteProviderPortLocationList.json
jashsing-mic Apr 1, 2022
903edb9
Delete expressRouteProviderPort.json
jashsing-mic Apr 1, 2022
21af2ee
Delete expressRouteProviderPortList.json
jashsing-mic Apr 1, 2022
bf4c3de
Delete expressRouteProviderPortLocationList.json
jashsing-mic Apr 1, 2022
20afa0e
Update expressRouteProviderPort.json
jashsing-mic Apr 6, 2022
30c25e5
Update expressRouteCrossConnection.json
jashsing-mic Apr 6, 2022
857af93
Update expressRouteProviderPort.json
jashsing-mic Apr 7, 2022
5acdad4
Create expressRouteProviderPort.json
jashsing-mic Apr 7, 2022
4e83b60
Delete expressRouteProviderPort.json
jashsing-mic Apr 7, 2022
e6eaaa4
Update expressRouteProviderPortList.json
jashsing-mic Apr 7, 2022
5ee38f4
Update expressRouteProviderPortLocationList.json
jashsing-mic Apr 7, 2022
85822dc
Update readme.md
jashsing-mic Apr 8, 2022
26277c5
Update expressRouteProviderPort.json
jashsing-mic Apr 8, 2022
da77583
Update readme.md
jashsing-mic Apr 8, 2022
1bd5bc8
Update expressRouteProviderPort.json
jashsing-mic Apr 11, 2022
e96af52
Update readme.md
jashsing-mic Apr 24, 2022
17fc3ab
Rename expressRouteProviderPortLocationList.json to expressRouteProvi…
jashsing-mic Apr 24, 2022
f23f08a
Update expressRouteProviderPort.json
jashsing-mic Apr 24, 2022
b370868
Update expressRouteProviderPort.json
jashsing-mic Apr 29, 2022
190132c
Update expressRouteProviderPort.json
jashsing-mic Apr 29, 2022
90efc51
Update custom-words.txt
jashsing-mic Apr 29, 2022
63fc1c2
Update expressRouteProviderPort.json
jashsing-mic May 9, 2022
22f5971
Update expressRouteProviderPort.json
jashsing-mic May 9, 2022
a2f9dcd
Update expressRouteProviderPortList.json
jashsing-mic May 9, 2022
5b654b4
Update expressRouteProviderPort.json
jashsing-mic May 10, 2022
7a32c9d
Update expressRouteProviderPort.json
jashsing-mic May 10, 2022
5090b33
Update expressRouteProviderPort.json
jashsing-mic May 10, 2022
91d7589
Update expressRouteProviderPort.json
jashsing-mic May 10, 2022
4d1f3de
Update expressRouteProviderPort.json
jashsing-mic May 10, 2022
e18bd11
Update expressRouteProviderPort.json
jashsing-mic May 10, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
{
"parameters": {
"api-version": "2021-08-01",
"subscriptionId": "subid"
},
"responses": {
"200": {
"body": {
"value": [
{
"portPairDescriptor": "bvtazureixpportpair1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"portPairDescriptor": "bvtazureixpportpair1",

Invalid, according to your definition this is part of your "properties" bag. There's a well known set of top level properties (e.g. id, type), cannot add another arbitrary top-level property.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix in your examples please.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"id": "/subscriptions/subid/providers/Microsoft.Network/ExpressRoutePortsLocations/SiliconValley/bvtazureixpportpair1",
"type": "Microsoft.Network/expressRouteProviderPort",
"location": "uswest",
"etag": "W/\"c0e6477e-8150-4d4f-9bf6-bb10e6acb63a\"",
"properties": {
"portPairDescriptor": "bvtazureixpportpair",
"primaryAzurePort": "bvtazureixp01",
"secondaryAzurePort": "bvtazureixp01",
"peeringLocation": "SiliconValley",
"overprovisionFactor": 4,
"portBandwidthInMbps": 4000,
"usedBandwidthInMbps": 2500,
"remainingBandwidthInMbps": 1500
}
},
{
"portPairDescriptor": "bvtazureixpportpair2",
"id": "/subscriptions/subid/providers/Microsoft.Network/ExpressRoutePortsLocations/SiliconValley/bvtazureixpportpair2",
"type": "Microsoft.Network/expressRouteProviderPort",
"location": "uswest",
"etag": "W/\"c0e6477e-8150-4d4f-9bf6-bb10e6acb63a\"",
"properties": {
"portPairDescriptor": "bvtazureixpportpair2",
"primaryAzurePort": "bvtazureixp02",
"secondaryAzurePort": "bvtazureixp02",
"peeringLocation": "seattle",
"overprovisionFactor": 4,
"portBandwidthInMbps": 4000,
"usedBandwidthInMbps": 1200,
"remainingBandwidthInMbps": 1800
}
}
]
}
}
}
}

Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
{
"parameters": {
"api-version": "2021-08-01",
"locationName": "SiliconValley",
"subscriptionId": "subid"
},
"responses": {
"200": {
"body": {
"value": [
{
"portPairDescriptor": "bvtazureixpportpair1",
"id": "/subscriptions/subid/providers/Microsoft.Network/ExpressRoutePortsLocations/SiliconValley/bvtazureixpportpair1",
"type": "Microsoft.Network/expressRouteProviderPort",
"location": "uswest",
"etag": "W/\"c0e6477e-8150-4d4f-9bf6-bb10e6acb63a\"",
"properties": {
"portPairDescriptor": "bvtazureixpportpair",
"primaryAzurePort": "bvtazureixp01",
"secondaryAzurePort": "bvtazureixp01",
"peeringLocation": "SiliconValley",
"overprovisionFactor": 4,
"portBandwidthInMbps": 4000,
"usedBandwidthInMbps": 2500,
"remainingBandwidthInMbps": 1500
}
}
]
}
}
}
}

Original file line number Diff line number Diff line change
@@ -0,0 +1,206 @@
{
"swagger": "2.0",
"info": {
"title": "NetworkManagementClient",
"description": "The Microsoft Azure Network management API provides a RESTful set of web services that interact with Microsoft Azure Networks service to manage your network resources. The API has entities that capture the relationship between an end user and the Microsoft Azure Networks service.",
"version": "2021-08-01"
},
"host": "management.azure.com",
"schemes": [
"https"
],
"consumes": [
"application/json"
],
"produces": [
"application/json"
],
"security": [
{
"azure_auth": [
"user_impersonation"
]
}
],
"securityDefinitions": {
"azure_auth": {
"type": "oauth2",
"authorizationUrl": "https://login.microsoftonline.com/common/oauth2/authorize",
"flow": "implicit",
"description": "Azure Active Directory OAuth2 Flow.",
"scopes": {
"user_impersonation": "impersonate your user account"
}
}
},
"paths": {
"/subscriptions/{subscriptionId}/providers/Microsoft.Network/expressRouteProviderPorts": {
"get": {
"tags": [
"ExpressRouteProviderPorts"
],
"operationId": "ExpressRouteProviderPortsLocation_List",
"description": "Retrieves all the ExpressRouteProviderPorts in a subscription.",
"parameters": [
{
"$ref": "./network.json#/parameters/ApiVersionParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
},
{
"name": "$filter",
"in": "query",
"required": false,
"type": "string",
"description": "The filter to apply on the operation. For example, you can use $filter=location eq '{state}'."
},
],
"responses": {
"200": {
"description": "Request successful. The operation returns a list of ExpressRouteProviderPort resources at a location. If there are no ports for the provider, an empty list is returned.",
"schema": {
"$ref": "#/definitions/ExpressRouteProviderPortListResult"
}
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "./network.json#/definitions/CloudError"
}
}
},
"x-ms-examples": {
"ExpressRouteProviderPortList": {
"$ref": "./examples/ExpressRouteProviderPortList.json"
},
"ExpressRouteProviderPortList": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use different name instead of duplicated name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"$ref": "./examples/ExpressRouteProviderPortLocationList.json"
},
}
}
},
"/subscriptions/{subscriptionId}/providers/Microsoft.Network/expressRouteProviderPorts/{providerport}": {
"get": {
"tags": [
"ExpressRouteProviderPorts"
],
"operationId": "ExpressRouteProviderPort",
"description": "Retrieves detail of a provider port.",
"parameters": [
{
"$ref": "./network.json#/parameters/ApiVersionParameter"
},
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "./network.json#/parameters/ProviderPortParameter"
},
],
"responses": {
"200": {
"description": "Request successful. The operation returns detail of individual provider port resources. If there is no port, an empty result is returned.",
"schema": {
"$ref": "#/definitions/ExpressRouteProviderPort"
}
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "./network.json#/definitions/CloudError"
}
}
},
"x-ms-examples": {
"ExpressRouteProviderPort": {
"$ref": "./examples/ExpressRouteProviderPort.json"
}
}
}
},
},
"definitions": {
"ExpressRouteProviderPortProperties": {
"properties": {
"portPairDescriptor": {
"readOnly": true,
"type": "string",
"description": "The name of the port pair."
},
"primaryAzurePort": {
"readOnly": true,
"type": "string",
"description": "The name of the primary port."
},
"secondaryAzurePort": {
"readOnly": true,
"type": "string",
"description": "The name of the secondary port."
},
"peeringLocation": {
"type": "string",
"description": "The peering location of the port pair."
},
"overprovisionFactor": {
"type": "integer",
"format": "int32",
"description": "Overprovisioning factor for the port pair."
},
"portBandwidthInMbps": {
"type": "integer",
"format": "int32",
"description": "Bandwidth of the port in Mbps"
},
"usedBandwidthInMbps": {
"type": "integer",
"format": "int32",
"description": "Used Bandwidth of the port in Mbps"
},
"remainingBandwidthInMbps": {
"type": "integer",
"format": "int32",
"description": "Remaining Bandwidth of the port in Mbps"
}
},
"description": "Properties of ExpressRouteProviderPort."
},
"ExpressRouteProviderPort": {
"properties": {
"properties": {
"x-ms-client-flatten": true,
"$ref": "#/definitions/ExpressRouteProviderPortProperties",
"description": "Properties of the express route Service Provider Port."
},
"etag": {
"readOnly": true,
"type": "string",
"description": "A unique read-only string that changes whenever the resource is updated."
}
},
"allOf": [
{
"$ref": "./network.json#/definitions/Resource"
}
],
"description": "ExpressRouteProviderPort resource."
},
"ExpressRouteProviderPortListResult": {
"properties": {
"value": {
"type": "array",
"items": {
"$ref": "#/definitions/ExpressRouteProviderPort"
},
"description": "A list of ExpressRouteProviderPort resources."
},
"nextLink": {
"readOnly": true,
"type": "string",
"description": "The URL to get the next set of results."
}
},
"description": "Response for ListExpressRouteProviderPort API service call."
}
}
}