API changes for Provider Ports #18484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @jashsing-mic Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is adding a path that was not found in the old version. New: azure-rest-api-specs/blob/e18bd1158c504936d0137fd565028737d747290f/revision:3783:13 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Network/stable/2021-08-01/loadBalancer.json#L6:5 |
️❌LintDiff: 1 Errors, 2 Warnings failed [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
- Linted configuring files (Based on target branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
| Rule | Message |
|---|---|
|
The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/privateLinkServices/{serviceName}/privateLinkResources is missing. Location: Microsoft.Network/stable/2021-08-01/expressRouteProviderPort.json#L36 |
| 'GET' operation 'ExpressRouteProviderPort' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Network/stable/2021-08-01/expressRouteProviderPort.json#L85 |
|
| Based on the response model schema, operation 'ExpressRouteProviderPortsLocation_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Network/stable/2021-08-01/expressRouteProviderPort.json#L38 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
|
Thank you for your contribution jashsing-mic! We will review the pull request and get back to you soon. |
|
Hi @jashsing-mic, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
|
raych1
reviewed
Mar 31, 2022
| @@ -0,0 +1,33 @@ | |||
| { | |||
There was a problem hiding this comment.
Can you move example json to ./examples folder?
There was a problem hiding this comment.
Done ..Moved to example folder
|
@jashsing-mic , can you read through the first comment of this PR and check on appropriate items so that ARM can be notified for the review? |
rkmanda
reviewed
Apr 1, 2022
| "info": { | ||
| "title": "NetworkManagementClient", | ||
| "description": "The Microsoft Azure Network management API provides a RESTful set of web services that interact with Microsoft Azure Networks service to manage your network resources. The API has entities that capture the relationship between an end user and the Microsoft Azure Networks service.", | ||
| "version": "2020-03-01" |
rkmanda
reviewed
Apr 1, 2022
| "body": { | ||
| "value": [ | ||
| { | ||
| "portPairDescriptor": "bvtazureixpportpair1", |
fixed syntax issue
added in readme file
|
@jashsing-mic , please resolve the CI check failures. Good to start with SemanticValidation, LintDiff, ModelValidation, SpellCheck, PrettierCheck ... |
|
NewApiVersionRequired reason: |
|
LGTM in case the review of failed jobs would be succeeded. Overwise your relatively urgent changes won't be in any future version without that cherry pick |
|
Close this one as we have another PR as replacement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.