Dev containerservice microsoft.container service 2020 09 01 #10634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/2020-07-01 to version 2020-09-01
* add cluster autoscaler profile for september api * add to spell check
* add ephemeral os api types * add example link * fix default appearance
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-net - Release
|
azure-resource-manager-schemas - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Aug 28, 2020
yungezz
reviewed
Aug 31, 2020
| "description": "The collection value.", | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/definitions/PrivateLinkResource" |
There was a problem hiding this comment.
could you pls use https://github.com/Azure/azure-rest-api-specs/blob/master/specification/common-types/resource-management/v1/privatelinks.json#L99 ? We're trying to use common definition for privatelink cross services for consistency. cc @allenjzhang .
There was a problem hiding this comment.
we can't use the common definition for this currently, there are some differences, like 'readonly' field.
Had talked this to Catherine offline, she is okay with it.
| } | ||
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedClusters/{resourceName}/resolvePrivateLinkServiceId": { |
There was a problem hiding this comment.
seems this operation is specific to aks. It's little confusing of "resolve private link service Id", from return type it should be "private link resource"?
There was a problem hiding this comment.
None of the stuff here is new. This is a merge from the dev branch to master. Nothing here is new.
There was a problem hiding this comment.
for "resolve private link service Id", it returns the private link resource as expected. BTW, privatelinkserviceId is part of private link resource.
|
cc @allenjzhang since this PR contains adding privatelink support. |
|
since new api added, add label "WaitForARMFeedback" |
|
@marwanad synced with me offline, changes in this PR is reviewed before merging to feature branch. For private link, here's the PR https://github.com/Azure/azure-rest-api-specs/pull/10548/files. I do see some issues there. Will trigger an email for further discussion. |
* update readme for sdks * update the remaining readme.md * fix space
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Aug 31, 2020
malopMSFT
reviewed
Aug 31, 2020
| "privateEndpoint": { | ||
| "id": "/subscriptions/subid2/resourceGroups/rg2/providers/Microsoft.Network/privateEndpoints/pe2" | ||
| }, | ||
| "privateLinkServiceConnectionState": { |
There was a problem hiding this comment.
missing description and actiosRequired
NRP Spec section 7.4:
There was a problem hiding this comment.
these are AKS API instead of NRP API. They won't be invoked by NRP
There was a problem hiding this comment.
I know is AKS API, still those properties would be missing like all other Privately Linkable Resources
malopMSFT
reviewed
Aug 31, 2020
| "privateEndpoint": { | ||
| "id": "/subscriptions/subid2/resourceGroups/rg2/providers/Microsoft.Network/privateEndpoints/pe2" | ||
| }, | ||
| "privateLinkServiceConnectionState": { |
There was a problem hiding this comment.
missing description and actionsRequired
NRP Spec section 7.4:
malopMSFT
reviewed
Aug 31, 2020
| "parameters": { | ||
| "properties": { | ||
| "privateLinkServiceConnectionState": { | ||
| "status": "Approved" |
There was a problem hiding this comment.
missing description and actionsRequired
NRP Spec section 7.4:
malopMSFT
reviewed
Aug 31, 2020
| "requiredMembers": [ | ||
| "management" | ||
| ], | ||
| "privateLinkServiceID": "/subscriptions/subid2/resourceGroups/rg2/providers/Microsoft.Network/privateLinkServices/plsName" |
There was a problem hiding this comment.
It would be more clear to have it here, and AKS already have logic to make sure PLSID is only exposed to NRP calls. I would like to have it as a part of swagger, unless you don't want to have swagger for these APIs.
malopMSFT
reviewed
Aug 31, 2020
| "name": "management", | ||
| "type": "Microsoft.ContainerService/managedClusters/privateLinkResources", | ||
| "groupId": "management", | ||
| "requiredMembers": [ |
There was a problem hiding this comment.
missing requiredZoneNames property
NRP Spec section 7.5
There was a problem hiding this comment.
This is implemented with spec Private Link for AKS, not the 1st party spec. requiredZoneNames is not used there.
There was a problem hiding this comment.
Sounds good, let's take it for next iteration once supported
malopMSFT
reviewed
Aug 31, 2020
| @@ -0,0 +1,18 @@ | |||
| { | |||
There was a problem hiding this comment.
is this API required on Swagger @ajinkyapotdarvjti ?
|
#sign-off |
yungezz
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.