Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more flags to the autoscaler profile #10587

Conversation

marwanad
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Adds the following list of parameters:

			"skip-nodes-with-local-storage":    
			"skip-nodes-with-system-pods":      
			"max-empty-bulk-delete":           
			"expander":                        
			"new-pod-scale-up-delay":    
			"max-total-unready-percentage":  
			"ok-total-unready-count":

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 26, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 26, 2020

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 26, 2020

azure-sdk-for-python

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 4175a7d with merge commit dfe52a6cafc37d8ca101ef48acbb42406da7e0fa. SDK Automation 13.0.17.20200807.2
    [azure-mgmt-containerservice][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-07-01', '2019-04-01'} in label v2017_07_01
    [azure-mgmt-containerservice][after_scripts|python] WARNING:__main__:Guessing you want 2017-07-01 based on label v2017_07_01
  • ⚠️azure-mgmt-containerservice [View full logs
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-containerservice
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-containerservice
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-07-01', '2019-04-01'} in label v2017_07_01
    [after_scripts|python] WARNING:__main__:Guessing you want 2017-07-01 based on label v2017_07_01
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    No file is changed.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 26, 2020

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 26, 2020

azure-resource-manager-schemas

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 4175a7d with merge commit dfe52a6cafc37d8ca101ef48acbb42406da7e0fa. Schema Automation 13.0.17.20200807.2
  • ️✔️containerservice [View full logs]  [Preview Schema Changes]
      [after_scripts|node] PostProcessor finished successfully.
      [after_scripts|node]   5625 passing (1m)
      AzureResourceSchema has no registered package commands.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 26, 2020

    azure-sdk-for-js

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 4175a7d with merge commit dfe52a6cafc37d8ca101ef48acbb42406da7e0fa. SDK Automation 13.0.17.20200807.2
    • ️✔️@azure/arm-containerservice [View full logs]  [Preview SDK Changes]
      Only show 100 items here, please refer to log for details.
      [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] loaded rollup.config.js with warnings
      [npmPack] (!) Unused external imports
      [npmPack] default imported from external module 'rollup' but never used
      [npmPack] 
      [npmPack] ./esm/containerServiceClient.js → ./dist/arm-containerservice.js...
      [npmPack] created ./dist/arm-containerservice.js in 387ms
      [npmPack] npm notice 
      [npmPack] npm notice package: @azure/arm-containerservice@11.1.0
      [npmPack] npm notice === Tarball Contents === 
      [npmPack] npm notice 10.9kB  esm/operations/agentPools.js                         
      [npmPack] npm notice 1.6kB   esm/models/agentPoolsMappers.js                      
      [npmPack] npm notice 139.8kB dist/arm-containerservice.js                         
      [npmPack] npm notice 50.2kB  dist/arm-containerservice.min.js                     
      [npmPack] npm notice 1.9kB   esm/containerServiceClient.js                        
      [npmPack] npm notice 2.7kB   esm/containerServiceClientContext.js                 
      [npmPack] npm notice 345B    esm/models/index.js                                  
      [npmPack] npm notice 492B    esm/operations/index.js                              
      [npmPack] npm notice 26.9kB  esm/operations/managedClusters.js                    
      [npmPack] npm notice 1.6kB   esm/models/managedClustersMappers.js                 
      [npmPack] npm notice 60.0kB  esm/models/mappers.js                                
      [npmPack] npm notice 1.6kB   esm/operations/operations.js                         
      [npmPack] npm notice 442B    esm/models/operationsMappers.js                      
      [npmPack] npm notice 2.5kB   esm/models/parameters.js                             
      [npmPack] npm notice 7.2kB   esm/operations/privateEndpointConnections.js         
      [npmPack] npm notice 1.5kB   esm/models/privateEndpointConnectionsMappers.js      
      [npmPack] npm notice 1.0kB   rollup.config.js                                     
      [npmPack] npm notice 1.7kB   package.json                                         
      [npmPack] npm notice 457B    tsconfig.json                                        
      [npmPack] npm notice 3.4kB   esm/operations/agentPools.d.ts.map                   
      [npmPack] npm notice 5.4kB   esm/operations/agentPools.js.map                     
      [npmPack] npm notice 655B    esm/models/agentPoolsMappers.d.ts.map                
      [npmPack] npm notice 668B    esm/models/agentPoolsMappers.js.map                  
      [npmPack] npm notice 278.8kB dist/arm-containerservice.js.map                     
      [npmPack] npm notice 38.9kB  dist/arm-containerservice.min.js.map                 
      [npmPack] npm notice 731B    esm/containerServiceClient.d.ts.map                  
      [npmPack] npm notice 885B    esm/containerServiceClient.js.map                    
      [npmPack] npm notice 511B    esm/containerServiceClientContext.d.ts.map           
      [npmPack] npm notice 1.4kB   esm/containerServiceClientContext.js.map             
      [npmPack] npm notice 20.5kB  esm/models/index.d.ts.map                            
      [npmPack] npm notice 204B    esm/operations/index.d.ts.map                        
      [npmPack] npm notice 126B    esm/models/index.js.map                              
      [npmPack] npm notice 219B    esm/operations/index.js.map                          
      [npmPack] npm notice 6.9kB   esm/operations/managedClusters.d.ts.map              
      [npmPack] npm notice 12.5kB  esm/operations/managedClusters.js.map                
      [npmPack] npm notice 688B    esm/models/managedClustersMappers.d.ts.map           
      [npmPack] npm notice 701B    esm/models/managedClustersMappers.js.map             
      [npmPack] npm notice 2.6kB   esm/models/mappers.d.ts.map                          
      [npmPack] npm notice 31.8kB  esm/models/mappers.js.map                            
      [npmPack] npm notice 663B    esm/operations/operations.d.ts.map                   
      [npmPack] npm notice 908B    esm/operations/operations.js.map                     
      [npmPack] npm notice 202B    esm/models/operationsMappers.d.ts.map                
      [npmPack] npm notice 215B    esm/models/operationsMappers.js.map                  
      [npmPack] npm notice 588B    esm/models/parameters.d.ts.map                       
      [npmPack] npm notice 1.8kB   esm/models/parameters.js.map                         
      [npmPack] npm notice 2.3kB   esm/operations/privateEndpointConnections.d.ts.map   
      [npmPack] npm notice 3.4kB   esm/operations/privateEndpointConnections.js.map     
      [npmPack] npm notice 635B    esm/models/privateEndpointConnectionsMappers.d.ts.map
      [npmPack] npm notice 648B    esm/models/privateEndpointConnectionsMappers.js.map  
      [npmPack] npm notice 3.2kB   README.md                                            
      [npmPack] npm notice 9.9kB   esm/operations/agentPools.d.ts                       
      [npmPack] npm notice 18.0kB  src/operations/agentPools.ts                         
      [npmPack] npm notice 1.3kB   esm/models/agentPoolsMappers.d.ts                    
      [npmPack] npm notice 1.6kB   src/models/agentPoolsMappers.ts                      
      [npmPack] npm notice 1.3kB   esm/containerServiceClient.d.ts                      
      [npmPack] npm notice 1.9kB   src/containerServiceClient.ts                        
      [npmPack] npm notice 923B    esm/containerServiceClientContext.d.ts               
      [npmPack] npm notice 2.4kB   src/containerServiceClientContext.ts                 
      [npmPack] npm notice 71.5kB  esm/models/index.d.ts                                
      [npmPack] npm notice 176B    esm/operations/index.d.ts                            
      [npmPack] npm notice 68.7kB  src/models/index.ts                                  
      [npmPack] npm notice 460B    src/operations/index.ts                              
      [npmPack] npm notice 22.6kB  esm/operations/managedClusters.d.ts                  
      [npmPack] npm notice 41.0kB  src/operations/managedClusters.ts                    
      [npmPack] npm notice 1.3kB   esm/models/managedClustersMappers.d.ts               
      [npmPack] npm notice 1.6kB   src/models/managedClustersMappers.ts                 
      [npmPack] npm notice 4.0kB   esm/models/mappers.d.ts                              
      [npmPack] npm notice 47.8kB  src/models/mappers.ts                                
      [npmPack] npm notice 1.1kB   esm/operations/operations.d.ts                       
      [npmPack] npm notice 2.3kB   src/operations/operations.ts                         
      [npmPack] npm notice 132B    esm/models/operationsMappers.d.ts                    
      [npmPack] npm notice 404B    src/models/operationsMappers.ts                      
      [npmPack] npm notice 690B    esm/models/parameters.d.ts                           
      [npmPack] npm notice 2.5kB   src/models/parameters.ts                             
      [npmPack] npm notice 7.1kB   esm/operations/privateEndpointConnections.d.ts       
      [npmPack] npm notice 12.5kB  src/operations/privateEndpointConnections.ts         
      [npmPack] npm notice 1.2kB   esm/models/privateEndpointConnectionsMappers.d.ts    
      [npmPack] npm notice 1.5kB   src/models/privateEndpointConnectionsMappers.ts      
      [npmPack] npm notice 1.1kB   LICENSE.txt                                          
      [npmPack] npm notice === Tarball Details === 
      [npmPack] npm notice name:          @azure/arm-containerservice             
      [npmPack] npm notice version:       11.1.0                                  
      [npmPack] npm notice filename:      azure-arm-containerservice-11.1.0.tgz   
      [npmPack] npm notice package size:  114.7 kB                                
      [npmPack] npm notice unpacked size: 1.1 MB                                  
      [npmPack] npm notice shasum:        501221db0f91971d89b10830a7445a5239511e08
      [npmPack] npm notice integrity:     sha512-jfCAUmNyHcWZG[...]cRt79POT2HRPA==

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 26, 2020

    azure-sdk-for-net

    failed [Logs] [Expand Details]
    • Generate from 4175a7d with merge commit dfe52a6cafc37d8ca101ef48acbb42406da7e0fa. SDK Automation 13.0.17.20200807.2
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
    • Microsoft.Azure.Management.ContainerService [View full logs]  [Preview SDK Changes]
        Failed to create the package Microsoft.Azure.Management.ContainerService.
        Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=containerservice /v:n /p:SkipTests=true , {} 

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Aug 26, 2020

      azure-sdk-for-java

      ⚠️ warning [Logs] [Expand Details]

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Aug 26, 2020

      Trenton Generation

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Aug 26, 2020

      azure-sdk-for-python-track2

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @fengzhou-msft fengzhou-msft merged commit 92bda33 into Azure:dev-containerservice-Microsoft.ContainerService-2020-09-01 Aug 26, 2020
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Labels
      None yet
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      2 participants