Update bms.json #10030
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1302,32 +1302,6 @@ | |
| "modelAsString": true | ||
| } | ||
| }, | ||
| "lastBackupStatus": { | ||
| "description": "Last backup operation status. Possible values: Healthy, Unhealthy.", | ||
| "type": "string" | ||
|
|
@@ -1630,7 +1604,7 @@ | |
| } | ||
| } | ||
| }, | ||
| "ResourceHealthDetails": { | ||
| "description": "Health Details for backup items.", | ||
| "type": "object", | ||
| "properties": { | ||
|
|
@@ -1665,7 +1639,7 @@ | |
| "type": "object", | ||
| "allOf": [ | ||
| { | ||
| "$ref": "#/definitions/ResourceHealthDetails" | ||
| } | ||
| ] | ||
| }, | ||
|
|
@@ -1842,11 +1816,6 @@ | |
| "Passed", | ||
| "ActionRequired", | ||
| "ActionSuggested", | ||
|
There was a problem hiding this comment. remove enum value is kind of breaking change. this change is really required ? There was a problem hiding this comment. Hi @akning-ms these enum values were not populated in the service code. So it will not be a breaking change. There was a problem hiding this comment. agree with @akning-ms , removing an enum value is breaking change in SDK. |
||
| "Invalid" | ||
| ], | ||
| "type": "string", | ||
|
|
@@ -2208,32 +2177,6 @@ | |
| "modelAsString": true | ||
| } | ||
| }, | ||
| "extendedInfo": { | ||
| "$ref": "#/definitions/AzureVmWorkloadProtectedItemExtendedInfo", | ||
| "description": "Additional information for this backup item." | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing property is a breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @changlong-liu and @akning-ms ,
The properties which are being removed had never been enabled for the customer. We had done the Swagger and SDK changes for adding these properties and enums as part of a recent PR (#9711) and the service code to use these fields is not enabled. So no customer can possibly be using these properties. Based on internal feedback we have decided to follow a different approach so we wont be needing these properties anymore. So i would like to remove them. Even the enum "HealthStatus" needs to be removed/updated. If you can agree upon this then i can remove the enum also as part of this PR instead of a separate PR.
Thanks,
Labonya
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed with @akning-ms I have removed the enums.
Will update the SDK for this change along with the changes for a few more Swagger PRs which are currently in our pipeline.