Update bms.json #10030
Merged
Update bms.json #10030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-net - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Jul 3, 2020
|
Can one of the admins verify this patch? |
|
Hi @lapradh, Can you provide more info for why have this change, as it looks cause breaking change in stable version which is not allown. understand healthDetails is renamed, but seems healthstatus remove enum value, it may a breaking change. |
akning-ms
reviewed
Jul 3, 2020
| @@ -1842,11 +1816,6 @@ | |||
| "Passed", | |||
| "ActionRequired", | |||
| "ActionSuggested", | |||
| "Healthy", | |||
There was a problem hiding this comment.
remove enum value is kind of breaking change. this change is really required ?
There was a problem hiding this comment.
Hi @akning-ms these enum values were not populated in the service code. So it will not be a breaking change.
There was a problem hiding this comment.
agree with @akning-ms , removing an enum value is breaking change in SDK.
|
@changlong-liu to double confirm the swagger change which caused a sdk breaking change |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -1321,13 +1321,6 @@ | |||
| "modelAsString": true | |||
| } | |||
| }, | |||
| "healthDetails": { | |||
There was a problem hiding this comment.
removing property is a breaking change
There was a problem hiding this comment.
Hi @changlong-liu and @akning-ms ,
The properties which are being removed had never been enabled for the customer. We had done the Swagger and SDK changes for adding these properties and enums as part of a recent PR (#9711) and the service code to use these fields is not enabled. So no customer can possibly be using these properties. Based on internal feedback we have decided to follow a different approach so we wont be needing these properties anymore. So i would like to remove them. Even the enum "HealthStatus" needs to be removed/updated. If you can agree upon this then i can remove the enum also as part of this PR instead of a separate PR.
Thanks,
Labonya
There was a problem hiding this comment.
As discussed with @akning-ms I have removed the enums.
Will update the SDK for this change along with the changes for a few more Swagger PRs which are currently in our pipeline.
removed unused enums
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Not sure why so many checks are in waiting status. Is there any other change required from my side? |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
according to discuss offline, it is kind of revert for #9711, so approved the breaking for this PR, will request another SDK release again as sdk release on 5 Jun is wrong. |
4 tasks
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* Update bms.json * added back enum for health status with description to deprecate later * Update bms.json removed unused enums
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.