Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade typespec compiler to v0.63 and cadl ranch spec to the latest #2942
Upgrade typespec compiler to v0.63 and cadl ranch spec to the latest #2942
Changes from all commits
53895dd
25735b6
b15339a
8970047
f8b2f51
be8d014
31de3af
da760f5
2150af5
db82105
2a7547e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls help investigate why the model is removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because tcgc changes the operation status as LroInitial & Json. I think we could accept this breaking considering we would not directly use these models. If we have the usage for this model we could add usage decorator to mitigate this breaking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a breaking for HLC? if so, could you create an issue in #2367
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would assume no. Swagger side if the polling operation is exposed to public then during converting to tsp relevant models would be tagged with output usage and would include in modular.
Another thing is the health insight case in which we have nested result in body is not supported in hlc yet, so i would assume for this case the body type is directly exposed to public and its usage would be not limited to polling usage.