Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade typespec compiler to v0.63 and cadl ranch spec to the latest #2942

Merged
merged 11 commits into from
Dec 11, 2024

Conversation

v-jiaodi
Copy link
Member

@v-jiaodi v-jiaodi commented Dec 9, 2024

No description provided.

@@ -1069,49 +1067,6 @@ export function patientRecordArraySerializer(
});
}

/** Provides status details for long running operations. */
export interface HealthInsightsOperationStatusError {
/** The unique ID of the operation. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls help investigate why the model is removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because tcgc changes the operation status as LroInitial & Json. I think we could accept this breaking considering we would not directly use these models. If we have the usage for this model we could add usage decorator to mitigate this breaking.
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a breaking for HLC? if so, could you create an issue in #2367

Copy link
Member

@MaryGao MaryGao Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume no. Swagger side if the polling operation is exposed to public then during converting to tsp relevant models would be tagged with output usage and would include in modular.

Another thing is the health insight case in which we have nested result in body is not supported in hlc yet, so i would assume for this case the body type is directly exposed to public and its usage would be not limited to polling usage.

@MaryGao MaryGao marked this pull request as ready for review December 11, 2024 08:34
@MaryGao MaryGao changed the title Upgrade cadl ranch spec Upgrade typespec compiler and cadl ranch spec Dec 11, 2024
@MaryGao MaryGao changed the title Upgrade typespec compiler and cadl ranch spec Upgrade typespec compiler to v0.63 and cadl ranch spec Dec 11, 2024
@MaryGao MaryGao changed the title Upgrade typespec compiler to v0.63 and cadl ranch spec Upgrade typespec compiler to v0.63 and cadl ranch spec to the latest Dec 11, 2024
@MaryGao MaryGao merged commit fd50ff3 into Azure:main Dec 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants