Upgrade tcgc to ignore error model generation in MPG if it is not referenced #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaryGao
reviewed
Dec 4, 2024
packages/typespec-ts/test/modularUnit/scenarios/models/serialization/errorModels.md
Show resolved
Hide resolved
MaryGao
approved these changes
Dec 4, 2024
|
@MaryGao have we reviewed the breaking between HLC and Modular for this? |
|
@qiaozha The pr is to remove the orphan error models which we agreed to not generate them as a decision during MPG release. But let me know if we need to revisit this decision. But in modular we are lack of ability to serialize the non-success error responses but we can do this in HLC. I will create another issue to track this. Personally I prefer to mitigate this not accept. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2917