Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not generate error response model in MPG if it is not referenced #2917

Closed
Tracked by #2828
kazrael2119 opened this issue Nov 19, 2024 · 0 comments · Fixed by #2934
Closed
Tracked by #2828

Do not generate error response model in MPG if it is not referenced #2917

kazrael2119 opened this issue Nov 19, 2024 · 0 comments · Fixed by #2934
Assignees
Labels
HRLC p0 priority 0

Comments

@kazrael2119
Copy link
Contributor

kazrael2119 commented Nov 19, 2024

We have two cases for ErrorResponse ErrorDeail ErrorAdditionalInfo models:
1: these three models are all orphan models, in this case we need to remove these three models manually in src

2: ErrorDeail and ErrorAdditionalInfo are referenced from any other models but ErrorResponse not. In this case we only remove ErrorResponse in src

@kazrael2119 kazrael2119 changed the title Should we generate error response model in modular Do not generate error response model in modular if it is not referenced Nov 19, 2024
@qiaozha qiaozha added p0 priority 0 HRLC labels Nov 20, 2024
@MaryGao MaryGao assigned v-jiaodi and unassigned kazrael2119 Nov 25, 2024
@MaryGao MaryGao changed the title Do not generate error response model in modular if it is not referenced Do not generate error response model in MPG if it is not referenced Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HRLC p0 priority 0
Projects
None yet
4 participants