Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RLC: enable a flag for tsp interface as operation group name #1911

Merged
merged 17 commits into from
Jul 6, 2023
Merged

RLC: enable a flag for tsp interface as operation group name #1911

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f9b6a9b
Add operation group name as prefix name
MaryGao Jul 4, 2023
9331a5c
Enable operation group name
MaryGao Jul 4, 2023
e5ecd38
Enable the operation group prefix
MaryGao Jul 4, 2023
cfc54a6
Update swagger side
MaryGao Jul 4, 2023
b68f41d
update api view for loadtesting
MaryGao Jul 4, 2023
7007ee3
Disable the log
MaryGao Jul 4, 2023
aaa00e6
Update the generated code
MaryGao Jul 5, 2023
e5a7cdb
regen
MaryGao Jul 5, 2023
fffa694
Update the code
MaryGao Jul 5, 2023
746b442
Generate the code
MaryGao Jul 5, 2023
d9c1cb1
update internal code
MaryGao Jul 5, 2023
973a9f2
Revert changes
MaryGao Jul 5, 2023
8cb6942
Update .vscode/launch.json
MaryGao Jul 5, 2023
5f8a014
Update .vscode/launch.json
MaryGao Jul 5, 2023
c938140
update the context to rlc sdk context
MaryGao Jul 5, 2023
adf7a9a
revert changes
MaryGao Jul 5, 2023
fd163e0
fix uts
MaryGao Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@
"name": "[TypeSpec] Smoke Test Debug",
"request": "launch",
"cwd": "${workspaceFolder}/packages/typespec-test/test/openai_modular",

MaryGao marked this conversation as resolved.
Show resolved Hide resolved
"runtimeArgs": ["tsp", "compile", "./spec"],
"runtimeExecutable": "npx",
"skipFiles": ["<node_internals>/**"],
Expand Down
2 changes: 2 additions & 0 deletions packages/autorest.typescript/src/restLevelClient/transforms/transformOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,7 @@ export function transformOptions(model: CodeModel): RLCOptions {
options.credentialScopes = credentialScopes;
options.credentialKeyHeaderName = credentialKeyHeaderName;
options.sourceFrom = "Swagger";
// Always enable operation group prefix for swagger
options.enableOperationGroup = true;
return options;
}
5 changes: 4 additions & 1 deletion packages/rlc-common/src/buildClientDefinitions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,10 @@ function getOperationReturnTypeName(
operationGroupName &&
operationGroupName !== "Client"
) {
return `${pascalCase(operationGroupName)}${pascalCase(name)}`;
return normalizeName(
`${pascalCase(operationGroupName)}${pascalCase(name)}`,
NameType.Interface
);
}

return pascalCase(name);
Expand Down
1 change: 1 addition & 0 deletions packages/rlc-common/src/interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ export interface RLCOptions {
azureArm?: boolean;
sourceFrom?: "Cadl" | "Swagger";
isModularLibrary?: boolean;
enableOperationGroup?: boolean | string;
MaryGao marked this conversation as resolved.
Show resolved Hide resolved
}

export interface ServiceInfo {
Expand Down
1,470 changes: 735 additions & 735 deletions ...es/typespec-test/test/loadTest/generated/typespec-ts/review/load-testing.api.md
View file
Open in desktop

Large diffs are not rendered by default.

Loading