Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RLC: enable a flag for tsp interface as operation group name #1911

Merged
merged 17 commits into from
Jul 6, 2023
Merged

RLC: enable a flag for tsp interface as operation group name #1911

merged 17 commits into from
Jul 6, 2023

Conversation

MaryGao
Copy link
Member

@MaryGao MaryGao commented Jul 4, 2023

fixes #1910

@MaryGao MaryGao changed the title Enable interface name RLC: enable a flag for tsp interface as operation group name Jul 4, 2023
@MaryGao MaryGao marked this pull request as ready for review July 5, 2023 03:11
MaryGao
MaryGao commented Jul 5, 2023
View reviewed changes
.vscode/launch.json Outdated Show resolved Hide resolved
MaryGao
MaryGao commented Jul 5, 2023
View reviewed changes
.vscode/launch.json Outdated Show resolved Hide resolved
qiaozha
qiaozha reviewed Jul 5, 2023
View reviewed changes
Copy link
Member

@qiaozha qiaozha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we previously discussed, we should let the loadtesting case breaking, not sure choosing this one as the smoke test case is a good idea.

packages/typespec-ts/src/transform/transfromRLCOptions.ts Outdated Show resolved Hide resolved
packages/typespec-ts/src/transform/transfromRLCOptions.ts Outdated Show resolved Hide resolved
packages/typespec-ts/src/lib.ts Show resolved Hide resolved
packages/rlc-common/src/interfaces.ts Outdated Show resolved Hide resolved
MaryGao
MaryGao commented Jul 5, 2023
View reviewed changes
packages/typespec-test/test/loadTest/tspconfig.yaml
@@ -23,6 +23,7 @@ options:
generateMetadata: true
generateTest: true
azureSdkForJs: false
enableOperationGroup: true
Copy link
Member Author

@MaryGao MaryGao Jul 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to enable the flag because there are duplicated operation names in diff interface.

@MaryGao MaryGao merged commit 6bd1730 into main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiaozha qiaozha qiaozha approved these changes

@sarangan12 sarangan12 Awaiting requested review from sarangan12 sarangan12 is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RLC: enable a flag for tsp interface as operation group name
2 participants
@MaryGao @qiaozha