feat(barretenberg): Graph methods for circuit analysis (part 2) #12130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6a67e67 to
86f9a35
Compare
Rumata888
reviewed
Feb 27, 2025
|
|
||
| /** | ||
| all these tests check graph description for sha256 circuits. All circuits have to consist from 1 connected component | ||
| all these tests check graph description for sha256 circuits. All circuits have to consist of 1 connected component | ||
| */ | ||
|
|
||
| TEST(boomerang_stdlib_sha256, test_graph_for_sha256_55_bytes) |
There was a problem hiding this comment.
It's better to add separate descriptions to each test. If I go to the last one, I don't know that there is a description here.
Rumata888
reviewed
Feb 27, 2025
| EXPECT_EQ(variables_in_one_gate.size(), 0); | ||
| if (variables_in_one_gate.size() > 0) { | ||
| for (const auto& elem : variables_in_one_gate) { | ||
| info("elem == ", elem); |
There was a problem hiding this comment.
It's better to remove info from tests in the general case, but here it's not an issue since the branch is not being taken
Rumata888
reviewed
Feb 27, 2025
| auto variables_in_one_gate = graph.show_variables_in_one_gate(circuit_constructor); | ||
| bool result = num_connected_components == 256; | ||
| EXPECT_EQ(result, true); | ||
| [[maybe_unused]] auto variables_in_one_gate = graph.show_variables_in_one_gate(circuit_constructor); |
Rumata888
reviewed
Feb 27, 2025
| auto connected_components = graph.find_connected_components(); | ||
| EXPECT_EQ(connected_components.size(), 1); | ||
| auto variables_in_one_gate = graph.show_variables_in_one_gate(builder); | ||
| EXPECT_EQ(variables_in_one_gate.size(), 2); |
Rumata888
reviewed
Feb 27, 2025
| fq_ct b(witness_ct(&builder, fr(uint256_t(inputs[1]).slice(0, fq_ct::NUM_LIMB_BITS * 2))), | ||
| witness_ct(&builder, fr(uint256_t(inputs[1]).slice(fq_ct::NUM_LIMB_BITS * 2, fq_ct::NUM_LIMB_BITS * 4)))); | ||
| fq_ct c = a * b; | ||
| for (size_t i = 0; i < num_repetitions; ++i) { |
There was a problem hiding this comment.
There is no need to repeat these operations
Rumata888
reviewed
Feb 27, 2025
| { | ||
| auto builder = Builder(); | ||
| size_t num_repetitions = 4; | ||
| for (size_t i = 0; i < num_repetitions; ++i) { |
There was a problem hiding this comment.
There is no need to repeat these operations
Rumata888
reviewed
Feb 27, 2025
| { | ||
| auto builder = Builder(); | ||
| size_t num_repetitions = 10; | ||
| for (size_t i = 0; i < num_repetitions; ++i) { |
There was a problem hiding this comment.
Here and basically everywhere further there is no need to repeat operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues Graph Description for Ultra Circuit Builder.
There were added functions for processing:
There were tested primitives like Poseidon2s hash function, Dynamic Array and Bigfield. Poseidon and Dynamic Array have been fully tested. Bigfield has been tested halfway.
There has been completed function for arithmetic block. (q_arith == 3 case), and it processes fix_witness another way.
There was added new filtering mechanism for finalize_circuit() function using tau and range tags, filtering mechanism for RAM/ROM gate and filtering mechanism for variables that were fixed.
Also there was added new data structure for containing information about gates for every variable. It can be helpful in further filtering mechanisms or debugging process.
No vulnerabilities were found by static analyzer.