feat(barretenberg): Graph methods for circuit analysis (part 2) #12110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es and sha256 were testted
… some naming changes
Rumata888
reviewed
Feb 19, 2025
|
|
||
| TEST(boomerang_ultra_circuit_constructor, test_variable_gates_count_for_decompose) | ||
| TEST(ultra_circuit_constructor, test_variable_gates_count_for_decompose) |
There was a problem hiding this comment.
Why have you renamed all of these?
Rumata888
reviewed
Feb 19, 2025
|
|
||
| using byte_array_ct = byte_array<Builder>; | ||
| using packed_byte_array_ct = packed_byte_array<Builder>; | ||
| using field_ct = field_t<Builder>; | ||
|
|
||
| /** | ||
| all these tests check graph description for sha256 circuits. All circuits have to consist from 1 connected component |
Rumata888
reviewed
Feb 19, 2025
| using packed_byte_array_pt = packed_byte_array<Builder>; | ||
| using field_pt = field_t<Builder>; | ||
|
|
||
| void fix_vector(std::vector<field_pt>& vector) { |
313b5d6 to
29ff134
Compare
|
Replaced with #12130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues Graph Description for Ultra Circuit Builder.
There were added functions for processing:
There were tested primitives like Poseidon2s hash function, Dynamic Array and Bigfield. Poseidon and Dynamic Array have been fully tested. Bigfield has been tested halfway.
There has been completed function for arithmetic block. (q_arith == 3 case), and it processes fix_witness another way.
There was added new filtering mechanism for finalize_circuit() function using tau and range tags, filtering mechanism for RAM/ROM gate and filtering mechanism for variables that were fixed.
Also there was added new data structure for containing information about gates for every variable. It can be helpful in further filtering mechanisms or debugging process.
No vulnerabilities were found by static analyzer.