Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin dependencies #42335

Merged
merged 1 commit into from
May 19, 2020
Merged

Unpin dependencies #42335

merged 1 commit into from
May 19, 2020

Conversation

scinos
Copy link
Contributor

@scinos scinos commented May 18, 2020

Changes proposed in this Pull Request

Testing instructions

  • Verify all tests pass
  • Verify there are no new packages introduced: run find . -type d -name node_modules | xargs rm -fr && yarn && NODE_OPTIONS=--max_old_space_size=8192 yarn run effective-module-tree -o list in this branch and master (tested with commit fa6f0c1), save the output to a file and diff them.

@scinos scinos requested a review from a team as a code owner May 18, 2020 13:36
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@scinos scinos self-assigned this May 18, 2020
@scinos scinos added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Framework labels May 18, 2020
Copy link
Contributor

@griffbrad griffbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 LGTM

@scinos scinos merged commit 682329b into master May 19, 2020
@scinos scinos deleted the update/unpin-dependencies-6 branch May 19, 2020 07:41
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants