-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin dependencies (Part 3) #41927
Unpin dependencies (Part 3) #41927
Conversation
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌵
babel-preset-jest "^25.1.0" | ||
chalk "^3.0.0" | ||
slash "^3.0.0" | ||
|
||
babel-jest@^24.9.0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, do you know @scinos why yarn sometimes reorganizes the lock file like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect it is alphabetical and/or specificity order.
As babel-jest@25.1.0, babel-jest@^25.1.0
becomes babel-jest@^25.1.0
, it is moved below babel-jest@^24.9.0
Changes proposed in this Pull Request
Third round of unpinning dependencies.
Previous PRs:
Testing instructions
Verify there are no packages removed/added in yarn.lock
Validate the dependency tree has not changed:
find . -type d -name node_modules | xargs rm -fr && yarn && NODE_OPTIONS=--max_old_space_size=8192 yarn run effective-module-tree -o list > ../branch-tree
find . -type d -name node_modules | xargs rm -fr && yarn && NODE_OPTIONS=--max_old_space_size=8192 yarn run effective-module-tree -o list > ../master-tree
diff ../branch-tree ../master-tree