Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin dependencies (Part 3) #41927

Merged
merged 1 commit into from
May 11, 2020
Merged

Unpin dependencies (Part 3) #41927

merged 1 commit into from
May 11, 2020

Conversation

scinos
Copy link
Contributor

@scinos scinos commented May 7, 2020

Changes proposed in this Pull Request

Third round of unpinning dependencies.

Previous PRs:

Testing instructions

  • Verify there are no packages removed/added in yarn.lock

  • Validate the dependency tree has not changed:

    • Install dependencies and generate the tree for this branch: find . -type d -name node_modules | xargs rm -fr && yarn && NODE_OPTIONS=--max_old_space_size=8192 yarn run effective-module-tree -o list > ../branch-tree
    • Install dependencies and generate the tree for master (tested with 948b416): find . -type d -name node_modules | xargs rm -fr && yarn && NODE_OPTIONS=--max_old_space_size=8192 yarn run effective-module-tree -o list > ../master-tree
    • Diff both trees and check there are no differences: diff ../branch-tree ../master-tree

@scinos scinos requested review from a team as code owners May 7, 2020 09:15
@matticbot
Copy link
Contributor

@scinos scinos self-assigned this May 7, 2020
@scinos scinos added Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 7, 2020
@scinos scinos changed the title Unpin dependencies Unpin dependencies (Part 3) May 7, 2020
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌵

babel-preset-jest "^25.1.0"
chalk "^3.0.0"
slash "^3.0.0"

babel-jest@^24.9.0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, do you know @scinos why yarn sometimes reorganizes the lock file like this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect it is alphabetical and/or specificity order.

As babel-jest@25.1.0, babel-jest@^25.1.0 becomes babel-jest@^25.1.0, it is moved below babel-jest@^24.9.0

@scinos scinos merged commit 7a44054 into master May 11, 2020
@scinos scinos deleted the update/unpin-dependencies-3 branch May 11, 2020 06:29
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 11, 2020
@scinos scinos mentioned this pull request May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants