Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout CSS: move a CSS reset to main style #37064

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Layout CSS: move a CSS reset to main style #37064

merged 1 commit into from
Oct 25, 2019

Conversation

simison
Copy link
Member

@simison simison commented Oct 25, 2019 •
edited
Loading

Changes proposed in this Pull Request

  • Moves a reset to _main.scss stylesheet from layout, because that's where more generic type selectors styles like this belong.

Came up when refactoring stylesheets: #37020

@jsnajdr noted (#37020 (comment)):

The only thing outside .layout__content is the Masterbar and things inside it, notably Notifications. Notifications have their own .wpnc__main a { text-decoration: none } style, so they shouldn't get hurt by this change. I think it's good and safe move.

Testing instructions

  • Do all the links stay as they should in the header?

@simison simison added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Janitorial labels Oct 25, 2019
@simison simison requested a review from a team as a code owner October 25, 2019 11:19
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/move-layout-a-reset-to-main

@simison simison mentioned this pull request Oct 25, 2019
Closed
@simison simison changed the title Layout CSS: move a CSS reset to main style Layout CSS: move a CSS reset to main style Oct 25, 2019
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

jsnajdr
jsnajdr approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice incremental fix, let 🚢 it.

@simison simison merged commit 4b0113d into master Oct 25, 2019
@simison simison deleted the update/move-layout-a-reset-to-main branch October 25, 2019 11:42
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 25, 2019
@jasmussen jasmussen mentioned this pull request Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnajdr jsnajdr jsnajdr approved these changes

Assignees
No one assigned
Labels
[Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simison @matticbot @jsnajdr